newaddr: don't include "address" field.

Signed-off-by: Rusty Russell <[email protected]>
Changelog-Removed: JSON-RPC: `newaddr` no longer includes `address` field (deprecated in 0.7.1)

Author: rustyrussell

tests/test_misc.py

@@ -1771,14 +1771,6 @@ def test_newaddr(node_factory, chainparams):
     assert both['bech32'].startswith(chainparams['bip173_prefix'])
 
 
-def test_newaddr_deprecated(node_factory, chainparams):
-    l1 = node_factory.get_node(options={'allow-deprecated-apis': True})
-    p2sh = l1.rpc.newaddr('p2sh-segwit')
-    assert p2sh['address'].startswith(chainparams['p2sh_prefix'])
-    bech32 = l1.rpc.newaddr('bech32')
-    assert bech32['address'].startswith(chainparams['bip173_prefix'])
-
-
 def test_bitcoind_fail_first(node_factory, bitcoind, executor):
     """Make sure we handle spurious bitcoin-cli failures during startup
 

wallet/walletrpc.c

@@ -151,9 +151,6 @@ static struct command_result *json_newaddr(struct command *cmd,
 	}
 
 	response = json_stream_success(cmd);
-	if (deprecated_apis && *addrtype != ADDR_ALL)
-		json_add_string(response, "address",
-				*addrtype & ADDR_BECH32 ? bech32 : p2sh);
 	if (*addrtype & ADDR_BECH32)
 		json_add_string(response, "bech32", bech32);
 	if (*addrtype & ADDR_P2SH_SEGWIT)