Added missing SignMessage API call.

Author: ksedgwic

contrib/remote_hsmd/TODO.md

@@ -4,8 +4,8 @@ API Coverage
 
 ## Failing Tests
 
+# intermittent
 tests/test_connection.py::test_restart_many_payments
-tests/test_misc.py::test_signmessage
 
 
 #### proxy and server done
@@ -32,11 +32,11 @@ tests/test_misc.py::test_signmessage
     WIRE_HSM_SIGN_LOCAL_HTLC_TX
     WIRE_HSM_SIGN_REMOTE_HTLC_TO_US
     handle_check_future_secret
+    handle_sign_message
 
 #### need proxy and server
 
 handle_sign_funding_tx
-handle_sign_message
 
 Improvements
 ----------------------------------------------------------------

contrib/remote_hsmd/hsmd.c

@@ -2167,6 +2167,19 @@ static struct io_plan *handle_sign_message(struct io_conn *conn,
 	if (!fromwire_hsm_sign_message(tmpctx, msg_in, &msg))
 		return bad_req(conn, c, msg_in);
 
+	proxy_stat rv = proxy_handle_sign_message(msg, &rsig);
+	if (PROXY_PERMANENT(rv))
+		status_failed(STATUS_FAIL_INTERNAL_ERROR,
+		              "proxy_%s failed: %s", __FUNCTION__,
+			      proxy_last_message());
+	else if (!PROXY_SUCCESS(rv))
+		return bad_req_fmt(conn, c, msg_in,
+				   "proxy_%s error: %s", __FUNCTION__,
+				   proxy_last_message());
+	g_proxy_impl = PROXY_IMPL_MARSHALED;
+
+	/* FIXME - USE THE PROXIED VALUE WHEN SERVER SUPPORTS */
+
 	/* Prefixing by a known string means we'll never be convinced
 	 * to sign some gossip message, etc. */
 	sha256_update(&sctx, "Lightning Signed Message:",

contrib/remote_hsmd/proxy.cc

@@ -651,6 +651,48 @@ proxy_stat proxy_handle_sign_invoice(
 	}
 }
 
+proxy_stat proxy_handle_sign_message(
+	u8 *msg,
+	secp256k1_ecdsa_recoverable_signature *o_sig)
+{
+	status_debug(
+		"%s:%d %s self_id=%s msg=%s",
+		__FILE__, __LINE__, __FUNCTION__,
+		dump_node_id(&self_id).c_str(),
+		dump_hex(msg, tal_count(msg)).c_str()
+		);
+
+	last_message = "";
+	SignMessageRequest req;
+	req.set_message(msg, tal_count(msg));
+
+	ClientContext context;
+	SignMessageReply rsp;
+	Status status = stub->SignMessage(&context, req, &rsp);
+	if (status.ok()) {
+		// FIXME - UNCOMMENT WHEN SERVER IMPLEMENTS:
+#if 0
+		output_ecdsa_recoverable_signature(rsp.signature(), o_sig);
+#else
+		memset(o_sig, '\0', sizeof(*o_sig));
+#endif
+		status_debug("%s:%d %s self_id=%s sig=%s",
+			     __FILE__, __LINE__, __FUNCTION__,
+			     dump_node_id(&self_id).c_str(),
+			     dump_secp256k1_ecdsa_recoverable_signature(
+				     o_sig).c_str());
+		last_message = "success";
+		return PROXY_OK;
+	} else {
+		status_unusual("%s:%d %s: self_id=%s %s",
+			       __FILE__, __LINE__, __FUNCTION__,
+			       dump_node_id(&self_id).c_str(),
+			       status.error_message().c_str());
+		last_message = status.error_message();
+		return map_status(status);
+	}
+}
+
 proxy_stat proxy_handle_channel_update_sig(
 	struct bitcoin_blkid *chain_hash,
 	struct short_channel_id *scid,

contrib/remote_hsmd/proxy.h

@@ -80,6 +80,10 @@ proxy_stat proxy_handle_sign_invoice(
 	u8 *hrpu8,
 	secp256k1_ecdsa_recoverable_signature *o_sig);
 
+proxy_stat proxy_handle_sign_message(
+	u8 *msg,
+	secp256k1_ecdsa_recoverable_signature *o_sig);
+
 proxy_stat proxy_handle_channel_update_sig(
 	struct bitcoin_blkid *chain_hash,
 	struct short_channel_id *scid,