Added sign-message.

Author: ksedgwic

contrib/remote_hsmd/NOTES.md

@@ -67,6 +67,9 @@ Some popular tests:
 
     # check-future-secret
     export THETEST=tests/test_connection.py::test_dataloss_protection
+    
+    # sign-message
+    export THETEST=tests/test_misc.py::test_signmessage
 
 rust-lightning-signer
 ----------------------------------------------------------------

contrib/remote_hsmd/TODO.md

@@ -27,11 +27,11 @@ COMPLETE		proxy_stat proxy_handle_sign_penalty_to_us
 COMPLETE		proxy_stat proxy_handle_sign_commitment_tx
 COMPLETE		proxy_stat proxy_handle_sign_mutual_close_tx
 COMPLETE		proxy_stat proxy_handle_check_future_secret
+COMPLETE		proxy_stat proxy_handle_sign_message
 
 PARTIAL (-P2SH)	proxy_stat proxy_handle_sign_withdrawal_tx
 
 MARSHALED		proxy_stat proxy_init_hsm
-MARSHALED		proxy_stat proxy_handle_sign_message
 MARSHALED		proxy_stat proxy_handle_cannouncement_sig
 ```
 

contrib/remote_hsmd/hsmd.c

@@ -1811,10 +1811,7 @@ static struct io_plan *handle_sign_message(struct io_conn *conn,
 					   const u8 *msg_in)
 {
 	u8 *msg;
-	struct sha256_ctx sctx = SHA256_INIT;
-	struct sha256_double shad;
 	secp256k1_ecdsa_recoverable_signature rsig;
-	struct privkey node_pkey;
 
 	if (!fromwire_hsm_sign_message(tmpctx, msg_in, &msg))
 		return bad_req(conn, c, msg_in);
@@ -1828,26 +1825,7 @@ static struct io_plan *handle_sign_message(struct io_conn *conn,
 		return bad_req_fmt(conn, c, msg_in,
 				   "proxy_%s error: %s", __FUNCTION__,
 				   proxy_last_message());
-	g_proxy_impl = PROXY_IMPL_MARSHALED;
-
-	/* FIXME - USE THE PROXIED VALUE WHEN SERVER SUPPORTS */
-
-	/* Prefixing by a known string means we'll never be convinced
-	 * to sign some gossip message, etc. */
-	sha256_update(&sctx, "Lightning Signed Message:",
-		      strlen("Lightning Signed Message:"));
-	sha256_update(&sctx, msg, tal_count(msg));
-	sha256_double_done(&sctx, &shad);
-
-	node_key(&node_pkey, NULL);
-	/*~ By no small coincidence, this libsecp routine uses the exact
-	 * recovery signature format mandated by BOLT 11. */
-	if (!secp256k1_ecdsa_sign_recoverable(secp256k1_ctx, &rsig,
-                                              shad.sha.u.u8,
-                                              node_pkey.secret.data,
-                                              NULL, NULL)) {
-		return bad_req_fmt(conn, c, msg_in, "Failed to sign message");
-	}
+	g_proxy_impl = PROXY_IMPL_COMPLETE;
 
 	return req_reply(conn, c,
 			 take(towire_hsm_sign_message_reply(NULL, &rsig)));

contrib/remote_hsmd/proxy.cc

@@ -642,18 +642,14 @@ proxy_stat proxy_handle_sign_message(
 
 	last_message = "";
 	SignMessageRequest req;
+	marshal_node_id(&self_id, req.mutable_node_id());
 	req.set_message(msg, tal_count(msg));
 
 	ClientContext context;
 	RecoverableNodeSignatureReply rsp;
 	Status status = stub->SignMessage(&context, req, &rsp);
 	if (status.ok()) {
-		// FIXME - UNCOMMENT WHEN SERVER IMPLEMENTS:
-#if 0
 		unmarshal_ecdsa_recoverable_signature(rsp.signature(), o_sig);
-#else
-		memset(o_sig, '\0', sizeof(*o_sig));
-#endif
 		status_debug("%s:%d %s self_id=%s sig=%s",
 			     __FILE__, __LINE__, __FUNCTION__,
 			     dump_node_id(&self_id).c_str(),