Skip to content

Commit feef170

Browse files
committed
Skip dual funding tests which trigger policy failure
- "channel stub can only return point for commitment number zero" - likely caused by CLN commit c0cc285 - possibly we relax the check, may not be security critical - See issue https://gitlab.com/lightning-signer/validating-lightning-signer/-/issues/245
1 parent 445484a commit feef170

File tree

3 files changed

+3
-0
lines changed

3 files changed

+3
-0
lines changed

tests/test_connection.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1820,6 +1820,7 @@ def test_funding_external_wallet(node_factory, bitcoind):
18201820

18211821
@unittest.skipIf(TEST_NETWORK != 'regtest', 'elementsd doesnt yet support PSBT features we need')
18221822
@pytest.mark.openchannel('v1') # We manually turn on dual-funding for select nodes
1823+
@unittest.skipIf(os.getenv('SUBDAEMON').startswith('hsmd:remote_hsmd'), "commit c0cc285a causes: channel stub can only return point for commitment number zero")
18231824
def test_multifunding_v1_v2_mixed(node_factory, bitcoind):
18241825
'''
18251826
Simple test for multifundchannel, using v1 + v2

tests/test_opening.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,7 @@ def test_queryrates(node_factory, bitcoind):
6161
@unittest.skipIf(TEST_NETWORK != 'regtest', 'elementsd doesnt yet support PSBT features we need')
6262
@pytest.mark.developer("uses dev-disconnect")
6363
@pytest.mark.openchannel('v1') # Mixed v1 + v2, v2 manually turned on
64+
@unittest.skipIf(os.getenv('SUBDAEMON').startswith('hsmd:remote_hsmd'), "commit c0cc285a causes: channel stub can only return point for commitment number zero")
6465
def test_multifunding_v2_best_effort(node_factory, bitcoind):
6566
'''
6667
Check that best_effort flag works.

tests/test_plugin.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3447,6 +3447,7 @@ def test_block_added_notifications(node_factory, bitcoind):
34473447

34483448
@unittest.skipIf(TEST_NETWORK != 'regtest', 'elementsd doesnt yet support PSBT features we need')
34493449
@pytest.mark.developer("wants dev-announce-localhost so we see listnodes.addresses")
3450+
@unittest.skipIf(os.getenv('SUBDAEMON').startswith('hsmd:remote_hsmd'), "commit c0cc285a causes: channel stub can only return point for commitment number zero")
34503451
def test_sql(node_factory, bitcoind):
34513452
opts = {'experimental-offers': None,
34523453
'experimental-dual-fund': None,

0 commit comments

Comments
 (0)