Update java bindings with new generator and new upstream code

Author: TheBlueMatt

liblightningjni.so

@@ -1,5 +1,10 @@
 package org.ldk.enums;
 
+/**
+ * An error when accessing the chain via [`Access`].
+ * 
+ * [`Access`]: trait.Access.html
+ */
 public enum LDKAccessError {
 	LDKAccessError_UnknownChain,
 	LDKAccessError_UnknownTx,

src/main/java/org/ldk/enums/LDKAccessError.java

@@ -1,5 +1,8 @@
 package org.ldk.enums;
 
+/**
+ * An error enum representing a failure to persist a channel monitor update.
+ */
 public enum LDKChannelMonitorUpdateErr {
 	LDKChannelMonitorUpdateErr_TemporaryFailure,
 	LDKChannelMonitorUpdateErr_PermanentFailure,

src/main/java/org/ldk/enums/LDKChannelMonitorUpdateErr.java

@@ -1,5 +1,9 @@
 package org.ldk.enums;
 
+/**
+ * An enum that represents the speed at which we want a transaction to confirm used for feerate
+ * estimation.
+ */
 public enum LDKConfirmationTarget {
 	LDKConfirmationTarget_Background,
 	LDKConfirmationTarget_Normal,

src/main/java/org/ldk/enums/LDKConfirmationTarget.java

@@ -1,5 +1,8 @@
 package org.ldk.enums;
 
+/**
+ * An enum representing the available verbosity levels of the logger.
+ */
 public enum LDKLevel {
 	LDKLevel_Off,
 	LDKLevel_Error,

src/main/java/org/ldk/enums/LDKLevel.java

@@ -5,6 +5,11 @@
 import org.ldk.util.*;
 import java.util.Arrays;
 
+
+/**
+ * Indicates an error on the client's part (usually some variant of attempting to use too-low or
+ * too-high values)
+ */
 @SuppressWarnings("unchecked") // We correctly assign various generic arrays
 public class APIError extends CommonBase {
 	private APIError(Object _dummy, long ptr) { super(ptr); }

src/main/java/org/ldk/impl/bindings.java

@@ -5,6 +5,10 @@
 import org.ldk.util.*;
 import java.util.Arrays;
 
+
+/**
+ * An accept_channel message to be sent or received from a peer
+ */
 @SuppressWarnings("unchecked") // We correctly assign various generic arrays
 public class AcceptChannel extends CommonBase {
 	AcceptChannel(Object _dummy, long ptr) { super(ptr); }
@@ -14,144 +18,237 @@ protected void finalize() throws Throwable {
 		if (ptr != 0) { bindings.AcceptChannel_free(ptr); }
 	}
 
+	/**
+	 * A temporary channel ID, until the funding outpoint is announced
+	 */
 	public byte[] get_temporary_channel_id() {
 		byte[] ret = bindings.AcceptChannel_get_temporary_channel_id(this.ptr);
 		return ret;
 	}
 
+	/**
+	 * A temporary channel ID, until the funding outpoint is announced
+	 */
 	public void set_temporary_channel_id(byte[] val) {
 		bindings.AcceptChannel_set_temporary_channel_id(this.ptr, val);
 	}
 
+	/**
+	 * The threshold below which outputs on transactions broadcast by sender will be omitted
+	 */
 	public long get_dust_limit_satoshis() {
 		long ret = bindings.AcceptChannel_get_dust_limit_satoshis(this.ptr);
 		return ret;
 	}
 
+	/**
+	 * The threshold below which outputs on transactions broadcast by sender will be omitted
+	 */
 	public void set_dust_limit_satoshis(long val) {
 		bindings.AcceptChannel_set_dust_limit_satoshis(this.ptr, val);
 	}
 
+	/**
+	 * The maximum inbound HTLC value in flight towards sender, in milli-satoshi
+	 */
 	public long get_max_htlc_value_in_flight_msat() {
 		long ret = bindings.AcceptChannel_get_max_htlc_value_in_flight_msat(this.ptr);
 		return ret;
 	}
 
+	/**
+	 * The maximum inbound HTLC value in flight towards sender, in milli-satoshi
+	 */
 	public void set_max_htlc_value_in_flight_msat(long val) {
 		bindings.AcceptChannel_set_max_htlc_value_in_flight_msat(this.ptr, val);
 	}
 
+	/**
+	 * The minimum value unencumbered by HTLCs for the counterparty to keep in the channel
+	 */
 	public long get_channel_reserve_satoshis() {
 		long ret = bindings.AcceptChannel_get_channel_reserve_satoshis(this.ptr);
 		return ret;
 	}
 
+	/**
+	 * The minimum value unencumbered by HTLCs for the counterparty to keep in the channel
+	 */
 	public void set_channel_reserve_satoshis(long val) {
 		bindings.AcceptChannel_set_channel_reserve_satoshis(this.ptr, val);
 	}
 
+	/**
+	 * The minimum HTLC size incoming to sender, in milli-satoshi
+	 */
 	public long get_htlc_minimum_msat() {
 		long ret = bindings.AcceptChannel_get_htlc_minimum_msat(this.ptr);
 		return ret;
 	}
 
+	/**
+	 * The minimum HTLC size incoming to sender, in milli-satoshi
+	 */
 	public void set_htlc_minimum_msat(long val) {
 		bindings.AcceptChannel_set_htlc_minimum_msat(this.ptr, val);
 	}
 
+	/**
+	 * Minimum depth of the funding transaction before the channel is considered open
+	 */
 	public int get_minimum_depth() {
 		int ret = bindings.AcceptChannel_get_minimum_depth(this.ptr);
 		return ret;
 	}
 
+	/**
+	 * Minimum depth of the funding transaction before the channel is considered open
+	 */
 	public void set_minimum_depth(int val) {
 		bindings.AcceptChannel_set_minimum_depth(this.ptr, val);
 	}
 
+	/**
+	 * The number of blocks which the counterparty will have to wait to claim on-chain funds if they broadcast a commitment transaction
+	 */
 	public short get_to_self_delay() {
 		short ret = bindings.AcceptChannel_get_to_self_delay(this.ptr);
 		return ret;
 	}
 
+	/**
+	 * The number of blocks which the counterparty will have to wait to claim on-chain funds if they broadcast a commitment transaction
+	 */
 	public void set_to_self_delay(short val) {
 		bindings.AcceptChannel_set_to_self_delay(this.ptr, val);
 	}
 
+	/**
+	 * The maximum number of inbound HTLCs towards sender
+	 */
 	public short get_max_accepted_htlcs() {
 		short ret = bindings.AcceptChannel_get_max_accepted_htlcs(this.ptr);
 		return ret;
 	}
 
+	/**
+	 * The maximum number of inbound HTLCs towards sender
+	 */
 	public void set_max_accepted_htlcs(short val) {
 		bindings.AcceptChannel_set_max_accepted_htlcs(this.ptr, val);
 	}
 
+	/**
+	 * The sender's key controlling the funding transaction
+	 */
 	public byte[] get_funding_pubkey() {
 		byte[] ret = bindings.AcceptChannel_get_funding_pubkey(this.ptr);
 		return ret;
 	}
 
+	/**
+	 * The sender's key controlling the funding transaction
+	 */
 	public void set_funding_pubkey(byte[] val) {
 		bindings.AcceptChannel_set_funding_pubkey(this.ptr, val);
 	}
 
+	/**
+	 * Used to derive a revocation key for transactions broadcast by counterparty
+	 */
 	public byte[] get_revocation_basepoint() {
 		byte[] ret = bindings.AcceptChannel_get_revocation_basepoint(this.ptr);
 		return ret;
 	}
 
+	/**
+	 * Used to derive a revocation key for transactions broadcast by counterparty
+	 */
 	public void set_revocation_basepoint(byte[] val) {
 		bindings.AcceptChannel_set_revocation_basepoint(this.ptr, val);
 	}
 
+	/**
+	 * A payment key to sender for transactions broadcast by counterparty
+	 */
 	public byte[] get_payment_point() {
 		byte[] ret = bindings.AcceptChannel_get_payment_point(this.ptr);
 		return ret;
 	}
 
+	/**
+	 * A payment key to sender for transactions broadcast by counterparty
+	 */
 	public void set_payment_point(byte[] val) {
 		bindings.AcceptChannel_set_payment_point(this.ptr, val);
 	}
 
+	/**
+	 * Used to derive a payment key to sender for transactions broadcast by sender
+	 */
 	public byte[] get_delayed_payment_basepoint() {
 		byte[] ret = bindings.AcceptChannel_get_delayed_payment_basepoint(this.ptr);
 		return ret;
 	}
 
+	/**
+	 * Used to derive a payment key to sender for transactions broadcast by sender
+	 */
 	public void set_delayed_payment_basepoint(byte[] val) {
 		bindings.AcceptChannel_set_delayed_payment_basepoint(this.ptr, val);
 	}
 
+	/**
+	 * Used to derive an HTLC payment key to sender for transactions broadcast by counterparty
+	 */
 	public byte[] get_htlc_basepoint() {
 		byte[] ret = bindings.AcceptChannel_get_htlc_basepoint(this.ptr);
 		return ret;
 	}
 
+	/**
+	 * Used to derive an HTLC payment key to sender for transactions broadcast by counterparty
+	 */
 	public void set_htlc_basepoint(byte[] val) {
 		bindings.AcceptChannel_set_htlc_basepoint(this.ptr, val);
 	}
 
+	/**
+	 * The first to-be-broadcast-by-sender transaction's per commitment point
+	 */
 	public byte[] get_first_per_commitment_point() {
 		byte[] ret = bindings.AcceptChannel_get_first_per_commitment_point(this.ptr);
 		return ret;
 	}
 
+	/**
+	 * The first to-be-broadcast-by-sender transaction's per commitment point
+	 */
 	public void set_first_per_commitment_point(byte[] val) {
 		bindings.AcceptChannel_set_first_per_commitment_point(this.ptr, val);
 	}
 
+	/**
+	 * Creates a copy of the AcceptChannel
+	 */
 	public AcceptChannel clone() {
 		long ret = bindings.AcceptChannel_clone(this.ptr);
 		AcceptChannel ret_hu_conv = new AcceptChannel(null, ret);
 		ret_hu_conv.ptrs_to.add(this);
 		return ret_hu_conv;
 	}
 
+	/**
+	 * Serialize the AcceptChannel object into a byte array which can be read by AcceptChannel_read
+	 */
 	public byte[] write() {
 		byte[] ret = bindings.AcceptChannel_write(this.ptr);
 		return ret;
 	}
 
+	/**
+	 * Read a AcceptChannel from a byte array, created by AcceptChannel_write
+	 */
 	public static Result_AcceptChannelDecodeErrorZ constructor_read(byte[] ser) {
 		long ret = bindings.AcceptChannel_read(ser);
 		Result_AcceptChannelDecodeErrorZ ret_hu_conv = Result_AcceptChannelDecodeErrorZ.constr_from_ptr(ret);

src/main/java/org/ldk/structs/APIError.java

@@ -5,6 +5,10 @@
 import org.ldk.util.*;
 import java.util.Arrays;
 
+/**
+ * The `Access` trait defines behavior for accessing chain data and state, such as blocks and
+ * UTXOs.
+ */
 @SuppressWarnings("unchecked") // We correctly assign various generic arrays
 public class Access extends CommonBase {
 	final bindings.LDKAccess bindings_instance;
@@ -20,6 +24,13 @@ protected void finalize() throws Throwable {
 	}
 
 	public static interface AccessInterface {
+		/**
+		 * Returns the transaction output of a funding transaction encoded by [`short_channel_id`].
+		 * Returns an error if `genesis_hash` is for a different chain or if such a transaction output
+		 * is unknown.
+		 * 
+		 * [`short_channel_id`]: https://github.com/lightningnetwork/lightning-rfc/blob/master/07-routing-gossip.md#definition-of-short_channel_id
+		 */
 		Result_TxOutAccessErrorZ get_utxo(byte[] genesis_hash, long short_channel_id);
 	}
 	private static class LDKAccessHolder { Access held; }
@@ -34,6 +45,13 @@ public static Access new_impl(AccessInterface arg) {
 		});
 		return impl_holder.held;
 	}
+	/**
+	 * Returns the transaction output of a funding transaction encoded by [`short_channel_id`].
+	 * Returns an error if `genesis_hash` is for a different chain or if such a transaction output
+	 * is unknown.
+	 * 
+	 * [`short_channel_id`]: https://github.com/lightningnetwork/lightning-rfc/blob/master/07-routing-gossip.md#definition-of-short_channel_id
+	 */
 	public Result_TxOutAccessErrorZ get_utxo(byte[] genesis_hash, long short_channel_id) {
 		long ret = bindings.Access_get_utxo(this.ptr, genesis_hash, short_channel_id);
 		Result_TxOutAccessErrorZ ret_hu_conv = Result_TxOutAccessErrorZ.constr_from_ptr(ret);