Merge pull request #124 from TheBlueMatt/main

Update to 0.0.113

Author: TheBlueMatt

.github/workflows/build.yml

@@ -39,14 +39,15 @@ jobs:
           # Note this is a different endpoint, as we need one non-upstream commit!
           git clone https://git.bitcoin.ninja/rust-lightning
           cd rust-lightning
-          git checkout origin/2022-10-112-java-bindings
+          git checkout origin/2022-12-0.0.113-java-bindings
           cd ..
           git clone https://github.com/lightningdevkit/ldk-c-bindings
           cd ldk-c-bindings
-          git checkout 0.0.112
+          git checkout 0.0.113
       - name: Rebuild C bindings without STD
         run: |
           cd ldk-c-bindings
+          git config --global safe.directory "*"
           ./genbindings.sh ../rust-lightning false
       - name: Build and Test TS Debug Bindings for Node
         run: |
@@ -66,7 +67,7 @@ jobs:
           export HOME=/root/ # Github actions is apparently broken
           export PATH=$(pwd)/$(echo node-*/bin):$PATH
           # npx playwright install-deps is broken so we do it manually, see https://github.com/microsoft/playwright/issues/11165
-          apt-get install -y --no-install-recommends fonts-liberation libenchant-2-2 libicu71 libjpeg62-turbo libasound2 libatk-bridge2.0-0 libatk1.0-0 libatspi2.0-0 libcairo2 libcups2 libdbus-1-3 libdrm2 libegl1 libgbm1 libglib2.0-0 libgtk-3-0 libnspr4 libnss3 libpango-1.0-0 libx11-6 libx11-xcb1 libxcb1 libxcomposite1 libxdamage1 libxext6 libxfixes3 libxrandr2 libxshmfence1 xvfb fonts-noto-color-emoji fonts-unifont libfontconfig libfreetype6 xfonts-scalable fonts-ipafont-gothic fonts-wqy-zenhei fonts-tlwg-loma-otf ffmpeg libcairo-gobject2 libdbus-glib-1-2 libfontconfig1 libgdk-pixbuf2.0-0 libpangocairo-1.0-0 libpangoft2-1.0-0 libxcb-shm0 libxcursor1 libxi6 libxrender1 libxt6 gstreamer1.0-libav gstreamer1.0-plugins-bad gstreamer1.0-plugins-base gstreamer1.0-plugins-good libepoxy0 libevdev2 libgl1 libgles2 libgstreamer-gl1.0-0 libgstreamer1.0-0 libharfbuzz-icu0 libharfbuzz0b libhyphen0 libnotify4 libopenjp2-7 libopus0 libpng16-16 libsecret-1-0 libsoup2.4-1 libwayland-client0 libwayland-egl1 libwayland-server0 libwebp7 libwebpdemux2 libwoff1 libxkbcommon0 libxml2 libxslt1.1
+          apt-get install -y --no-install-recommends fonts-liberation libenchant-2-2 libicu72 libjpeg62-turbo libasound2 libatk-bridge2.0-0 libatk1.0-0 libatspi2.0-0 libcairo2 libcups2 libdbus-1-3 libdrm2 libegl1 libgbm1 libglib2.0-0 libgtk-3-0 libnspr4 libnss3 libpango-1.0-0 libx11-6 libx11-xcb1 libxcb1 libxcomposite1 libxdamage1 libxext6 libxfixes3 libxrandr2 libxshmfence1 xvfb fonts-noto-color-emoji fonts-unifont libfontconfig libfreetype6 xfonts-scalable fonts-ipafont-gothic fonts-wqy-zenhei fonts-tlwg-loma-otf ffmpeg libcairo-gobject2 libdbus-glib-1-2 libfontconfig1 libgdk-pixbuf2.0-0 libpangocairo-1.0-0 libpangoft2-1.0-0 libxcb-shm0 libxcursor1 libxi6 libxrender1 libxt6 gstreamer1.0-libav gstreamer1.0-plugins-bad gstreamer1.0-plugins-base gstreamer1.0-plugins-good libepoxy0 libevdev2 libgl1 libgles2 libgstreamer-gl1.0-0 libgstreamer1.0-0 libharfbuzz-icu0 libharfbuzz0b libhyphen0 libnotify4 libopenjp2-7 libopus0 libpng16-16 libsecret-1-0 libsoup2.4-1 libwayland-client0 libwayland-egl1 libwayland-server0 libwebp7 libwebpdemux2 libwoff1 libxkbcommon0 libxml2 libxslt1.1
           mkdir -p $HOME/.cache/ms-playwright # `playwright install` is too dumb to create this for us
           chmod -R 777 $HOME/
           npm i -D playwright
@@ -75,6 +76,7 @@ jobs:
         run: |
           export HOME=/root/ # Github actions is apparently broken
           export PATH=$(pwd)/$(echo node-*/bin):$PATH
+          git config --global safe.directory "*"
           ./genbindings.sh ./ldk-c-bindings/ wasm true true
           cd ts
           rm liblightningjs.wasm && ln -s $(pwd)/../liblightningjs_debug.wasm ./liblightningjs.wasm
@@ -130,11 +132,11 @@ jobs:
           # Note this is a different endpoint, as we need one non-upstream commit!
           git clone https://git.bitcoin.ninja/rust-lightning
           cd rust-lightning
-          git checkout origin/2022-10-112-java-bindings
+          git checkout origin/2022-12-0.0.113-java-bindings
           cd ..
           git clone https://github.com/lightningdevkit/ldk-c-bindings
           cd ldk-c-bindings
-          git checkout 0.0.112
+          git checkout 0.0.113
       - name: Rebuild C bindings, and check the sample app builds + links
         run: |
           cd ldk-c-bindings
@@ -185,11 +187,11 @@ jobs:
           # Note this is a different endpoint, as we need one non-upstream commit!
           git clone https://git.bitcoin.ninja/rust-lightning
           cd rust-lightning
-          git checkout origin/2022-10-112-java-bindings
+          git checkout origin/2022-12-0.0.113-java-bindings
           cd ..
           git clone https://github.com/lightningdevkit/ldk-c-bindings
           cd ldk-c-bindings
-          git checkout 0.0.112
+          git checkout 0.0.113
       - name: Rebuild C bindings, and check the sample app builds + links
         run: |
           cd ldk-c-bindings
@@ -288,11 +290,11 @@ jobs:
           # Note this is a different endpoint, as we need one non-upstream commit!
           git clone https://git.bitcoin.ninja/rust-lightning
           cd rust-lightning
-          git checkout origin/2022-10-112-java-bindings
+          git checkout origin/2022-12-0.0.113-java-bindings
           cd ..
           git clone https://github.com/lightningdevkit/ldk-c-bindings
           cd ldk-c-bindings
-          git checkout 0.0.112
+          git checkout 0.0.113
       - name: Checkout Android AAR binaries and artifacts
         run: |
           # Gitweb only allows snapshots of folders by providing the object hash, which we have to extract:
@@ -345,20 +347,20 @@ jobs:
     steps:
       - name: Install other Rust platforms
         run: rustup target install aarch64-apple-darwin
+      - name: Checkout source code
+        uses: actions/checkout@v2
+        with:
+          fetch-depth: 0
       - name: Fetch upstream LLVM/clang snapshot
         run: |
-          wget -O clang+llvm-14.0.5-x86_64-apple-darwin.tar.xz https://github.com/llvm/llvm-project/releases/download/llvmorg-14.0.5/clang+llvm-14.0.5-x86_64-apple-darwin.tar.xz
-          if [ "$(shasum -a 256 clang+llvm-14.0.5-x86_64-apple-darwin.tar.xz | awk '{ print $1 }')" != "66cf1b8e00289a567b2f5f740f068b7682e27ccf048647b836d3624376a64705" ]; then
+          wget -O clang+llvm-15.0.3-x86_64-apple-darwin.tar.xz https://github.com/llvm/llvm-project/releases/download/llvmorg-15.0.3/clang+llvm-15.0.3-x86_64-apple-darwin.tar.xz
+          if [ "$(shasum -a 256 clang+llvm-15.0.3-x86_64-apple-darwin.tar.xz | awk '{ print $1 }')" != "ac668586b2b3d068f1e43520a3ef0b1592e5dc3eff1a4a4b772e29803b428a69" ]; then
             echo "Bad hash"
             exit 1
           fi
       - name: Unpack upstream LLVM+clang and use it by default
         run: |
-          tar xvvf clang+llvm-14.0.5-x86_64-apple-darwin.tar.xz
-      - name: Checkout source code
-        uses: actions/checkout@v2
-        with:
-          fetch-depth: 0
+          tar xvvf clang+llvm-15.0.3-x86_64-apple-darwin.tar.xz
       - name: Install cbindgen
         run: cargo install cbindgen
       - name: Checkout Rust-Lightning and LDK-C-Bindings git
@@ -368,14 +370,14 @@ jobs:
           # Note this is a different endpoint, as we need one non-upstream commit!
           git clone https://git.bitcoin.ninja/rust-lightning
           cd rust-lightning
-          git checkout origin/2022-10-112-java-bindings
+          git checkout origin/2022-12-0.0.113-java-bindings
           cd ..
           git clone https://github.com/lightningdevkit/ldk-c-bindings
           cd ldk-c-bindings
-          git checkout 0.0.112
+          git checkout 0.0.113
       - name: Rebuild C bindings with upstream clang, and check the sample app builds + links
         run: |
-          export PATH=`pwd`/clang+llvm-14.0.5-x86_64-apple-darwin/bin:$PATH
+          export PATH=`pwd`/clang+llvm-15.0.3-x86_64-apple-darwin/bin:$PATH
           cd ldk-c-bindings
           CC=clang ./genbindings.sh ../rust-lightning true
       - name: Fetch OpenJDK 18
@@ -414,7 +416,7 @@ jobs:
           export LDK_GARBAGECOLLECTED_GIT_OVERRIDE="$(git describe --tag HEAD)"
           export JAVA_HOME=`pwd`/jdk-18.0.1.1.jdk/Contents/Home
           export PATH=$JAVA_HOME/bin:$PATH
-          export PATH=`pwd`/clang+llvm-14.0.5-x86_64-apple-darwin/bin:$PATH
+          export PATH=`pwd`/clang+llvm-15.0.3-x86_64-apple-darwin/bin:$PATH
           ./genbindings.sh ./ldk-c-bindings/ "-I$JAVA_HOME/include/ -I$JAVA_HOME/include/darwin -isysroot$(xcrun --show-sdk-path)" false false
 
           if [ "${{ matrix.platform }}" = "macos-11" ]; then

c_sharp/libcode.version

@@ -0,0 +1,4 @@
+{
+	global: CS_LDK_*;
+	local: *;
+};

c_sharp/src/org/ldk/enums/AccessError.cs

@@ -0,0 +1,13 @@
+namespace org { namespace ldk { namespace enums {/**
+ * An error when accessing the chain via [`Access`].
+ */
+public enum AccessError {
+	/**
+	 * The requested chain is unknown.
+	 */
+	LDKAccessError_UnknownChain,
+	/**
+	 * The requested transaction doesn't exist or hasn't confirmed.
+	 */
+	LDKAccessError_UnknownTx,
+}} } }

c_sharp/src/org/ldk/enums/COption_NoneZ.cs

@@ -0,0 +1,13 @@
+namespace org { namespace ldk { namespace enums {/**
+ * An enum which can either contain a  or not
+ */
+public enum COption_NoneZ {
+	/**
+	 * When we're in this state, this COption_NoneZ contains a
+	 */
+	LDKCOption_NoneZ_Some,
+	/**
+	 * When we're in this state, this COption_NoneZ contains nothing
+	 */
+	LDKCOption_NoneZ_None,
+}} } }

c_sharp/src/org/ldk/enums/ChannelMonitorUpdateStatus.cs

@@ -0,0 +1,84 @@
+namespace org { namespace ldk { namespace enums {/**
+ * An enum representing the status of a channel monitor update persistence.
+ */
+public enum ChannelMonitorUpdateStatus {
+	/**
+	 * The update has been durably persisted and all copies of the relevant [`ChannelMonitor`]
+	 * have been updated.
+	 * 
+	 * This includes performing any `fsync()` calls required to ensure the update is guaranteed to
+	 * be available on restart even if the application crashes.
+	 */
+	LDKChannelMonitorUpdateStatus_Completed,
+	/**
+	 * Used to indicate a temporary failure (eg connection to a watchtower or remote backup of
+	 * our state failed, but is expected to succeed at some point in the future).
+	 * 
+	 * Such a failure will \"freeze\" a channel, preventing us from revoking old states or
+	 * submitting new commitment transactions to the counterparty. Once the update(s) which failed
+	 * have been successfully applied, a [`MonitorEvent::Completed`] can be used to restore the
+	 * channel to an operational state.
+	 * 
+	 * Note that a given [`ChannelManager`] will *never* re-generate a [`ChannelMonitorUpdate`].
+	 * If you return this error you must ensure that it is written to disk safely before writing
+	 * the latest [`ChannelManager`] state, or you should return [`PermanentFailure`] instead.
+	 * 
+	 * Even when a channel has been \"frozen\", updates to the [`ChannelMonitor`] can continue to
+	 * occur (e.g. if an inbound HTLC which we forwarded was claimed upstream, resulting in us
+	 * attempting to claim it on this channel) and those updates must still be persisted.
+	 * 
+	 * No updates to the channel will be made which could invalidate other [`ChannelMonitor`]s
+	 * until a [`MonitorEvent::Completed`] is provided, even if you return no error on a later
+	 * monitor update for the same channel.
+	 * 
+	 * For deployments where a copy of ChannelMonitors and other local state are backed up in a
+	 * remote location (with local copies persisted immediately), it is anticipated that all
+	 * updates will return [`InProgress`] until the remote copies could be updated.
+	 * 
+	 * [`PermanentFailure`]: ChannelMonitorUpdateStatus::PermanentFailure
+	 * [`InProgress`]: ChannelMonitorUpdateStatus::InProgress
+	 * [`ChannelManager`]: crate::ln::channelmanager::ChannelManager
+	 */
+	LDKChannelMonitorUpdateStatus_InProgress,
+	/**
+	 * Used to indicate no further channel monitor updates will be allowed (likely a disk failure
+	 * or a remote copy of this [`ChannelMonitor`] is no longer reachable and thus not updatable).
+	 * 
+	 * When this is returned, [`ChannelManager`] will force-close the channel but *not* broadcast
+	 * our current commitment transaction. This avoids a dangerous case where a local disk failure
+	 * (e.g. the Linux-default remounting of the disk as read-only) causes [`PermanentFailure`]s
+	 * for all monitor updates. If we were to broadcast our latest commitment transaction and then
+	 * restart, we could end up reading a previous [`ChannelMonitor`] and [`ChannelManager`],
+	 * revoking our now-broadcasted state before seeing it confirm and losing all our funds.
+	 * 
+	 * Note that this is somewhat of a tradeoff - if the disk is really gone and we may have lost
+	 * the data permanently, we really should broadcast immediately. If the data can be recovered
+	 * with manual intervention, we'd rather close the channel, rejecting future updates to it,
+	 * and broadcast the latest state only if we have HTLCs to claim which are timing out (which
+	 * we do as long as blocks are connected).
+	 * 
+	 * In order to broadcast the latest local commitment transaction, you'll need to call
+	 * [`ChannelMonitor::get_latest_holder_commitment_txn`] and broadcast the resulting
+	 * transactions once you've safely ensured no further channel updates can be generated by your
+	 * [`ChannelManager`].
+	 * 
+	 * Note that at least one final [`ChannelMonitorUpdate`] may still be provided, which must
+	 * still be processed by a running [`ChannelMonitor`]. This final update will mark the
+	 * [`ChannelMonitor`] as finalized, ensuring no further updates (e.g. revocation of the latest
+	 * commitment transaction) are allowed.
+	 * 
+	 * Note that even if you return a [`PermanentFailure`] due to unavailability of secondary
+	 * [`ChannelMonitor`] copies, you should still make an attempt to store the update where
+	 * possible to ensure you can claim HTLC outputs on the latest commitment transaction
+	 * broadcasted later.
+	 * 
+	 * In case of distributed watchtowers deployment, the new version must be written to disk, as
+	 * state may have been stored but rejected due to a block forcing a commitment broadcast. This
+	 * storage is used to claim outputs of rejected state confirmed onchain by another watchtower,
+	 * lagging behind on block processing.
+	 * 
+	 * [`PermanentFailure`]: ChannelMonitorUpdateStatus::PermanentFailure
+	 * [`ChannelManager`]: crate::ln::channelmanager::ChannelManager
+	 */
+	LDKChannelMonitorUpdateStatus_PermanentFailure,
+}} } }

c_sharp/src/org/ldk/enums/ConfirmationTarget.cs

@@ -0,0 +1,18 @@
+namespace org { namespace ldk { namespace enums {/**
+ * An enum that represents the speed at which we want a transaction to confirm used for feerate
+ * estimation.
+ */
+public enum ConfirmationTarget {
+	/**
+	 * We are happy with this transaction confirming slowly when feerate drops some.
+	 */
+	LDKConfirmationTarget_Background,
+	/**
+	 * We'd like this transaction to confirm without major delay, but 12-18 blocks is fine.
+	 */
+	LDKConfirmationTarget_Normal,
+	/**
+	 * We'd like this transaction to confirm in the next few blocks.
+	 */
+	LDKConfirmationTarget_HighPriority,
+}} } }

c_sharp/src/org/ldk/enums/CreationError.cs

@@ -0,0 +1,28 @@
+namespace org { namespace ldk { namespace enums {/**
+ * Errors that may occur when constructing a new `RawInvoice` or `Invoice`
+ */
+public enum CreationError {
+	/**
+	 * The supplied description string was longer than 639 __bytes__ (see [`Description::new(...)`](./struct.Description.html#method.new))
+	 */
+	LDKCreationError_DescriptionTooLong,
+	/**
+	 * The specified route has too many hops and can't be encoded
+	 */
+	LDKCreationError_RouteTooLong,
+	/**
+	 * The Unix timestamp of the supplied date is less than zero or greater than 35-bits
+	 */
+	LDKCreationError_TimestampOutOfBounds,
+	/**
+	 * The supplied millisatoshi amount was greater than the total bitcoin supply.
+	 */
+	LDKCreationError_InvalidAmount,
+	/**
+	 * Route hints were required for this invoice and were missing. Applies to
+	 * [phantom invoices].
+	 * 
+	 * [phantom invoices]: crate::utils::create_phantom_invoice
+	 */
+	LDKCreationError_MissingRouteHints,
+}} } }

c_sharp/src/org/ldk/enums/Currency.cs

@@ -0,0 +1,25 @@
+namespace org { namespace ldk { namespace enums {/**
+ * Enum representing the crypto currencies (or networks) supported by this library
+ */
+public enum Currency {
+	/**
+	 * Bitcoin mainnet
+	 */
+	LDKCurrency_Bitcoin,
+	/**
+	 * Bitcoin testnet
+	 */
+	LDKCurrency_BitcoinTestnet,
+	/**
+	 * Bitcoin regtest
+	 */
+	LDKCurrency_Regtest,
+	/**
+	 * Bitcoin simnet
+	 */
+	LDKCurrency_Simnet,
+	/**
+	 * Bitcoin signet
+	 */
+	LDKCurrency_Signet,
+}} } }

c_sharp/src/org/ldk/enums/HTLCClaim.cs

@@ -0,0 +1,25 @@
+namespace org { namespace ldk { namespace enums {/**
+ * Describes the type of HTLC claim as determined by analyzing the witness.
+ */
+public enum HTLCClaim {
+	/**
+	 * Claims an offered output on a commitment transaction through the timeout path.
+	 */
+	LDKHTLCClaim_OfferedTimeout,
+	/**
+	 * Claims an offered output on a commitment transaction through the success path.
+	 */
+	LDKHTLCClaim_OfferedPreimage,
+	/**
+	 * Claims an accepted output on a commitment transaction through the timeout path.
+	 */
+	LDKHTLCClaim_AcceptedTimeout,
+	/**
+	 * Claims an accepted output on a commitment transaction through the success path.
+	 */
+	LDKHTLCClaim_AcceptedPreimage,
+	/**
+	 * Claims an offered/accepted output on a commitment transaction through the revocation path.
+	 */
+	LDKHTLCClaim_Revocation,
+}} } }

c_sharp/src/org/ldk/enums/IOError.cs

@@ -0,0 +1,23 @@
+namespace org { namespace ldk { namespace enums {/**
+ * Represents an IO Error. Note that some information is lost in the conversion from Rust.
+ */
+public enum IOError {
+	LDKIOError_NotFound,
+	LDKIOError_PermissionDenied,
+	LDKIOError_ConnectionRefused,
+	LDKIOError_ConnectionReset,
+	LDKIOError_ConnectionAborted,
+	LDKIOError_NotConnected,
+	LDKIOError_AddrInUse,
+	LDKIOError_AddrNotAvailable,
+	LDKIOError_BrokenPipe,
+	LDKIOError_AlreadyExists,
+	LDKIOError_WouldBlock,
+	LDKIOError_InvalidInput,
+	LDKIOError_InvalidData,
+	LDKIOError_TimedOut,
+	LDKIOError_WriteZero,
+	LDKIOError_Interrupted,
+	LDKIOError_Other,
+	LDKIOError_UnexpectedEof,
+}} } }