Skip to content

Commit 042816a

Browse files
joostjagerjoostjager
committed
Integration test logging to stdout
1 parent 0f1d66c commit 042816a

File tree

6 files changed

+66
-67
lines changed

6 files changed

+66
-67
lines changed

‎tests/common/mod.rs‎

Lines changed: 29 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -227,7 +227,7 @@ pub(crate) fn random_node_alias() -> Option<NodeAlias> {
227227
Some(NodeAlias(bytes))
228228
}
229229

230-
pub(crate) fn random_config(anchor_channels: bool) -> TestConfig {
230+
pub(crate) fn random_config(anchor_channels: bool, node_id: String) -> TestConfig {
231231
let mut node_config = Config::default();
232232

233233
if !anchor_channels {
@@ -249,7 +249,9 @@ pub(crate) fn random_config(anchor_channels: bool) -> TestConfig {
249249
println!("Setting random LDK node alias: {:?}", alias);
250250
node_config.node_alias = alias;
251251

252-
TestConfig { node_config, ..Default::default() }
252+
let log_writer = TestLogWriter::Custom(Arc::new(MultiNodeLogger::new(node_id)));
253+
254+
TestConfig { node_config, log_writer }
253255
}
254256

255257
#[cfg(feature = "uniffi")]
@@ -274,24 +276,29 @@ pub(crate) struct TestConfig {
274276
macro_rules! setup_builder {
275277
($builder: ident, $config: expr) => {
276278
#[cfg(feature = "uniffi")]
277-
let $builder = Builder::from_config($config.clone());
279+
let $builder = Builder::from_config($config.node_config.clone());
280+
#[cfg(not(feature = "uniffi"))]
281+
let mut $builder = Builder::from_config($config.node_config.clone());
282+
278283
#[cfg(not(feature = "uniffi"))]
279-
let mut $builder = Builder::from_config($config.clone());
284+
crate::common::set_builder_log_writer(&mut $builder, &$config);
280285
};
281286
}
282287

283288
pub(crate) use setup_builder;
284289

290+
use crate::common::logging::MultiNodeLogger;
291+
285292
pub(crate) fn setup_two_nodes(
286293
chain_source: &TestChainSource, allow_0conf: bool, anchor_channels: bool,
287294
anchors_trusted_no_reserve: bool,
288295
) -> (TestNode, TestNode) {
289296
println!("== Node A ==");
290-
let config_a = random_config(anchor_channels);
297+
let config_a = random_config(anchor_channels, "node_a".to_string());
291298
let node_a = setup_node(chain_source, config_a, None);
292299

293300
println!("\n== Node B ==");
294-
let mut config_b = random_config(anchor_channels);
301+
let mut config_b = random_config(anchor_channels, "node_b".to_string());
295302
if allow_0conf {
296303
config_b.node_config.trusted_peers_0conf.push(node_a.node_id());
297304
}
@@ -311,7 +318,7 @@ pub(crate) fn setup_two_nodes(
311318
pub(crate) fn setup_node(
312319
chain_source: &TestChainSource, config: TestConfig, seed_bytes: Option<Vec<u8>>,
313320
) -> TestNode {
314-
setup_builder!(builder, config.node_config);
321+
setup_builder!(builder, config);
315322
match chain_source {
316323
TestChainSource::Esplora(electrsd) => {
317324
let esplora_url = format!("http://{}", electrsd.esplora_url.as_ref().unwrap());
@@ -350,17 +357,7 @@ pub(crate) fn setup_node(
350357
},
351358
}
352359

353-
match &config.log_writer {
354-
TestLogWriter::FileWriter => {
355-
builder.set_filesystem_logger(None, None);
356-
},
357-
TestLogWriter::LogFacade => {
358-
builder.set_log_facade_logger();
359-
},
360-
TestLogWriter::Custom(custom_log_writer) => {
361-
builder.set_custom_logger(Arc::clone(custom_log_writer));
362-
},
363-
}
360+
set_builder_log_writer(&mut builder, &config);
364361

365362
if let Some(seed) = seed_bytes {
366363
#[cfg(feature = "uniffi")]
@@ -383,6 +380,20 @@ pub(crate) fn setup_node(
383380
node
384381
}
385382

383+
pub(crate) fn set_builder_log_writer(builder: &mut Builder, config: &TestConfig) {
384+
match &config.log_writer {
385+
TestLogWriter::FileWriter => {
386+
builder.set_filesystem_logger(None, None);
387+
},
388+
TestLogWriter::LogFacade => {
389+
builder.set_log_facade_logger();
390+
},
391+
TestLogWriter::Custom(custom_log_writer) => {
392+
builder.set_custom_logger(Arc::clone(custom_log_writer));
393+
},
394+
}
395+
}
396+
386397
pub(crate) fn generate_blocks_and_wait<E: ElectrumApi>(
387398
bitcoind: &BitcoindClient, electrs: &E, num: usize,
388399
) {

‎tests/integration_tests_cln.rs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ fn test_cln() {
4444
common::generate_blocks_and_wait(&bitcoind_client, &electrs_client, 1);
4545

4646
// Setup LDK Node
47-
let config = common::random_config(true);
47+
let config = common::random_config(true, "ldk_node".to_string());
4848
let mut builder = Builder::from_config(config.node_config);
4949
builder.set_chain_source_esplora("http://127.0.0.1:3002".to_string(), None);
5050

‎tests/integration_tests_lnd.rs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ async fn test_lnd() {
4141
common::generate_blocks_and_wait(&bitcoind_client, &electrs_client, 1);
4242

4343
// Setup LDK Node
44-
let config = common::random_config(true);
44+
let config = common::random_config(true, "ldk_node".to_string());
4545
let mut builder = Builder::from_config(config.node_config);
4646
builder.set_chain_source_esplora("http://127.0.0.1:3002".to_string(), None);
4747

‎tests/integration_tests_rust.rs‎

Lines changed: 28 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ use common::{
1212
expect_channel_pending_event, expect_channel_ready_event, expect_event,
1313
expect_payment_claimable_event, expect_payment_received_event, expect_payment_successful_event,
1414
generate_blocks_and_wait,
15-
logging::MultiNodeLogger,
1615
logging::{init_log_logger, validate_log_entry, TestLogWriter},
1716
open_channel, open_channel_push_amt, premine_and_distribute_funds, premine_blocks, prepare_rbf,
1817
random_config, random_listening_addresses, setup_bitcoind_and_electrsd, setup_builder,
@@ -151,10 +150,10 @@ fn multi_hop_sending() {
151150

152151
// Setup and fund 5 nodes
153152
let mut nodes = Vec::new();
154-
for _ in 0..5 {
155-
let config = random_config(true);
153+
for node_idx in 0..5 {
154+
let config = random_config(true, format!("node_{}", node_idx));
156155
let sync_config = EsploraSyncConfig { background_sync_config: None };
157-
setup_builder!(builder, config.node_config);
156+
setup_builder!(builder, config);
158157
builder.set_chain_source_esplora(esplora_url.clone(), Some(sync_config));
159158
let node = builder.build().unwrap();
160159
node.start().unwrap();
@@ -244,15 +243,15 @@ fn multi_hop_sending() {
244243
#[test]
245244
fn start_stop_reinit() {
246245
let (bitcoind, electrsd) = setup_bitcoind_and_electrsd();
247-
let config = random_config(true);
246+
let config = random_config(true, "single_node".to_string());
248247

249248
let esplora_url = format!("http://{}", electrsd.esplora_url.as_ref().unwrap());
250249

251250
let test_sync_store: Arc<dyn KVStoreSync + Sync + Send> =
252251
Arc::new(TestSyncStore::new(config.node_config.storage_dir_path.clone().into()));
253252

254253
let sync_config = EsploraSyncConfig { background_sync_config: None };
255-
setup_builder!(builder, config.node_config);
254+
setup_builder!(builder, config);
256255
builder.set_chain_source_esplora(esplora_url.clone(), Some(sync_config));
257256

258257
let node = builder.build_with_store(Arc::clone(&test_sync_store)).unwrap();
@@ -276,9 +275,6 @@ fn start_stop_reinit() {
276275
node.sync_wallets().unwrap();
277276
assert_eq!(node.list_balances().spendable_onchain_balance_sats, expected_amount.to_sat());
278277

279-
let log_file = format!("{}/ldk_node.log", config.node_config.clone().storage_dir_path);
280-
assert!(std::path::Path::new(&log_file).exists());
281-
282278
node.stop().unwrap();
283279
assert_eq!(node.stop(), Err(NodeError::NotRunning));
284280

@@ -289,7 +285,7 @@ fn start_stop_reinit() {
289285
assert_eq!(node.stop(), Err(NodeError::NotRunning));
290286
drop(node);
291287

292-
setup_builder!(builder, config.node_config);
288+
setup_builder!(builder, config);
293289
builder.set_chain_source_esplora(esplora_url.clone(), Some(sync_config));
294290

295291
let reinitialized_node = builder.build_with_store(Arc::clone(&test_sync_store)).unwrap();
@@ -601,7 +597,7 @@ fn onchain_wallet_recovery() {
601597

602598
let seed_bytes = vec![42u8; 64];
603599

604-
let original_config = random_config(true);
600+
let original_config = random_config(true, "original_node".to_string());
605601
let original_node = setup_node(&chain_source, original_config, Some(seed_bytes.clone()));
606602

607603
let premine_amount_sat = 100_000;
@@ -640,7 +636,7 @@ fn onchain_wallet_recovery() {
640636
drop(original_node);
641637

642638
// Now we start from scratch, only the seed remains the same.
643-
let recovered_config = random_config(true);
639+
let recovered_config = random_config(true, "recovered_node".to_string());
644640
let recovered_node = setup_node(&chain_source, recovered_config, Some(seed_bytes));
645641

646642
recovered_node.sync_wallets().unwrap();
@@ -693,17 +689,17 @@ fn run_rbf_test(is_insert_block: bool) {
693689
let chain_source_esplora = TestChainSource::Esplora(&electrsd);
694690

695691
macro_rules! config_node {
696-
($chain_source: expr, $anchor_channels: expr) => {{
697-
let config_a = random_config($anchor_channels);
692+
($chain_source: expr, $anchor_channels: expr, $node_id: expr) => {{
693+
let config_a = random_config($anchor_channels, $node_id);
698694
let node = setup_node(&$chain_source, config_a, None);
699695
node
700696
}};
701697
}
702698
let anchor_channels = false;
703699
let nodes = vec![
704-
config_node!(chain_source_electrsd, anchor_channels),
705-
config_node!(chain_source_bitcoind, anchor_channels),
706-
config_node!(chain_source_esplora, anchor_channels),
700+
config_node!(chain_source_electrsd, anchor_channels, "node_electrsd".to_string()),
701+
config_node!(chain_source_bitcoind, anchor_channels, "node_bitcoind".to_string()),
702+
config_node!(chain_source_esplora, anchor_channels, "node_esplora".to_string()),
707703
];
708704

709705
let (bitcoind, electrs) = (&bitcoind.client, &electrsd.client);
@@ -811,7 +807,7 @@ fn run_rbf_test(is_insert_block: bool) {
811807
#[test]
812808
fn sign_verify_msg() {
813809
let (_bitcoind, electrsd) = setup_bitcoind_and_electrsd();
814-
let config = random_config(true);
810+
let config = random_config(true, "single_node".to_string());
815811
let chain_source = TestChainSource::Esplora(&electrsd);
816812
let node = setup_node(&chain_source, config, None);
817813

@@ -1136,31 +1132,23 @@ fn static_invoice_server() {
11361132
let (bitcoind, electrsd) = setup_bitcoind_and_electrsd();
11371133
let chain_source = TestChainSource::Esplora(&electrsd);
11381134

1139-
let mut config_sender = random_config(true);
1135+
let mut config_sender = random_config(true, "sender ".to_string());
11401136
config_sender.node_config.listening_addresses = None;
11411137
config_sender.node_config.node_alias = None;
1142-
config_sender.log_writer =
1143-
TestLogWriter::Custom(Arc::new(MultiNodeLogger::new("sender ".to_string())));
11441138
let node_sender = setup_node(&chain_source, config_sender, None);
11451139

1146-
let mut config_sender_lsp = random_config(true);
1140+
let mut config_sender_lsp = random_config(true, "sender_lsp ".to_string());
11471141
config_sender_lsp.node_config.async_payment_services_enabled = true;
1148-
config_sender_lsp.log_writer =
1149-
TestLogWriter::Custom(Arc::new(MultiNodeLogger::new("sender_lsp ".to_string())));
11501142
let node_sender_lsp = setup_node(&chain_source, config_sender_lsp, None);
11511143

1152-
let mut config_receiver_lsp = random_config(true);
1144+
let mut config_receiver_lsp = random_config(true, "receiver_lsp".to_string());
11531145
config_receiver_lsp.node_config.async_payment_services_enabled = true;
1154-
config_receiver_lsp.log_writer =
1155-
TestLogWriter::Custom(Arc::new(MultiNodeLogger::new("receiver_lsp".to_string())));
11561146

11571147
let node_receiver_lsp = setup_node(&chain_source, config_receiver_lsp, None);
11581148

1159-
let mut config_receiver = random_config(true);
1149+
let mut config_receiver = random_config(true, "receiver ".to_string());
11601150
config_receiver.node_config.listening_addresses = None;
11611151
config_receiver.node_config.node_alias = None;
1162-
config_receiver.log_writer =
1163-
TestLogWriter::Custom(Arc::new(MultiNodeLogger::new("receiver ".to_string())));
11641152
let node_receiver = setup_node(&chain_source, config_receiver, None);
11651153

11661154
let address_sender = node_sender.onchain_payment().new_address().unwrap();
@@ -1253,7 +1241,7 @@ fn test_node_announcement_propagation() {
12531241
let chain_source = TestChainSource::Esplora(&electrsd);
12541242

12551243
// Node A will use both listening and announcement addresses
1256-
let mut config_a = random_config(true);
1244+
let mut config_a = random_config(true, "node_a".to_string());
12571245
let node_a_alias_string = "ldk-node-a".to_string();
12581246
let mut node_a_alias_bytes = [0u8; 32];
12591247
node_a_alias_bytes[..node_a_alias_string.as_bytes().len()]
@@ -1265,7 +1253,7 @@ fn test_node_announcement_propagation() {
12651253
config_a.node_config.announcement_addresses = Some(node_a_announcement_addresses.clone());
12661254

12671255
// Node B will only use listening addresses
1268-
let mut config_b = random_config(true);
1256+
let mut config_b = random_config(true, "node_b".to_string());
12691257
let node_b_alias_string = "ldk-node-b".to_string();
12701258
let mut node_b_alias_bytes = [0u8; 32];
12711259
node_b_alias_bytes[..node_b_alias_string.as_bytes().len()]
@@ -1525,8 +1513,8 @@ fn lsps2_client_service_integration() {
15251513
max_client_to_self_delay: 1024,
15261514
};
15271515

1528-
let service_config = random_config(true);
1529-
setup_builder!(service_builder, service_config.node_config);
1516+
let service_config = random_config(true, "service_node".to_string());
1517+
setup_builder!(service_builder, service_config);
15301518
service_builder.set_chain_source_esplora(esplora_url.clone(), Some(sync_config));
15311519
service_builder.set_liquidity_provider_lsps2(lsps2_service_config);
15321520
let service_node = service_builder.build().unwrap();
@@ -1535,15 +1523,15 @@ fn lsps2_client_service_integration() {
15351523
let service_node_id = service_node.node_id();
15361524
let service_addr = service_node.listening_addresses().unwrap().first().unwrap().clone();
15371525

1538-
let client_config = random_config(true);
1539-
setup_builder!(client_builder, client_config.node_config);
1526+
let client_config = random_config(true, "client_node".to_string());
1527+
setup_builder!(client_builder, client_config);
15401528
client_builder.set_chain_source_esplora(esplora_url.clone(), Some(sync_config));
15411529
client_builder.set_liquidity_source_lsps2(service_node_id, service_addr, None);
15421530
let client_node = client_builder.build().unwrap();
15431531
client_node.start().unwrap();
15441532

1545-
let payer_config = random_config(true);
1546-
setup_builder!(payer_builder, payer_config.node_config);
1533+
let payer_config = random_config(true, "payer_node".to_string());
1534+
setup_builder!(payer_builder, payer_config);
15471535
payer_builder.set_chain_source_esplora(esplora_url.clone(), Some(sync_config));
15481536
let payer_node = payer_builder.build().unwrap();
15491537
payer_node.start().unwrap();
@@ -1729,7 +1717,7 @@ fn facade_logging() {
17291717
let chain_source = TestChainSource::Esplora(&electrsd);
17301718

17311719
let logger = init_log_logger(LevelFilter::Trace);
1732-
let mut config = random_config(false);
1720+
let mut config = random_config(false, "single_node".to_string());
17331721
config.log_writer = TestLogWriter::LogFacade;
17341722

17351723
println!("== Facade logging starts ==");
@@ -1813,7 +1801,7 @@ async fn drop_in_async_context() {
18131801
let chain_source = TestChainSource::Esplora(&electrsd);
18141802
let seed_bytes = vec![42u8; 64];
18151803

1816-
let config = random_config(true);
1804+
let config = random_config(true, "single_node".to_string());
18171805
let node = setup_node(&chain_source, config, Some(seed_bytes));
18181806
node.stop().unwrap();
18191807
}

‎tests/integration_tests_vss.rs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ fn channel_full_cycle_with_vss_store() {
1717
let (bitcoind, electrsd) = common::setup_bitcoind_and_electrsd();
1818
println!("== Node A ==");
1919
let esplora_url = format!("http://{}", electrsd.esplora_url.as_ref().unwrap());
20-
let config_a = common::random_config(true);
20+
let config_a = common::random_config(true, "node_a".to_string());
2121
let mut builder_a = Builder::from_config(config_a.node_config);
2222
builder_a.set_chain_source_esplora(esplora_url.clone(), None);
2323
let vss_base_url = std::env::var("TEST_VSS_BASE_URL").unwrap();
@@ -31,7 +31,7 @@ fn channel_full_cycle_with_vss_store() {
3131
node_a.start().unwrap();
3232

3333
println!("\n== Node B ==");
34-
let config_b = common::random_config(true);
34+
let config_b = common::random_config(true, "node_b".to_string());
3535
let mut builder_b = Builder::from_config(config_b.node_config);
3636
builder_b.set_chain_source_esplora(esplora_url.clone(), None);
3737
let node_b = builder_b

‎tests/reorg_test.rs‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,17 +22,17 @@ proptest! {
2222
let chain_source_esplora = TestChainSource::Esplora(&electrsd);
2323

2424
macro_rules! config_node {
25-
($chain_source: expr, $anchor_channels: expr) => {{
26-
let config_a = random_config($anchor_channels);
25+
($chain_source: expr, $anchor_channels: expr, $node_id: expr) => {{
26+
let config_a = random_config($anchor_channels, $node_id);
2727
let node = setup_node(&$chain_source, config_a, None);
2828
node
2929
}};
3030
}
3131
let anchor_channels = true;
3232
let nodes = vec![
33-
config_node!(chain_source_electrsd, anchor_channels),
34-
config_node!(chain_source_bitcoind, anchor_channels),
35-
config_node!(chain_source_esplora, anchor_channels),
33+
config_node!(chain_source_electrsd, anchor_channels, "node_electrsd".to_string()),
34+
config_node!(chain_source_bitcoind, anchor_channels, "node_bitcoind".to_string()),
35+
config_node!(chain_source_esplora, anchor_channels, "node_esplora".to_string()),
3636
];
3737

3838
let (bitcoind, electrs) = (&bitcoind.client, &electrsd.client);

0 commit comments

Comments
 (0)