Cleanup poll_and_update_listeners_inner logic

.. now that we don't manually need to propagate anymore.

Author: tnull

src/chain/bitcoind.rs

@@ -329,9 +329,7 @@ impl BitcoindChainSource {
 				},
 				Err(e) => {
 					log_error!(self.logger, "Failed to poll for chain data: {:?}", e);
-					let res = Err(Error::TxSyncFailed);
-					self.wallet_polling_status.lock().unwrap().propagate_result_to_subscribers(res);
-					return res;
+					return Err(Error::TxSyncFailed);
 				},
 			}
 		};
@@ -360,9 +358,7 @@ impl BitcoindChainSource {
 			Ok(_) => {},
 			Err(e) => {
 				log_error!(self.logger, "Failed to poll for chain data: {:?}", e);
-				let res = Err(Error::TxSyncFailed);
-				self.wallet_polling_status.lock().unwrap().propagate_result_to_subscribers(res);
-				return res;
+				return Err(Error::TxSyncFailed);
 			},
 		}
 
@@ -388,9 +384,7 @@ impl BitcoindChainSource {
 			},
 			Err(e) => {
 				log_error!(self.logger, "Failed to poll for mempool transactions: {:?}", e);
-				let res = Err(Error::TxSyncFailed);
-				self.wallet_polling_status.lock().unwrap().propagate_result_to_subscribers(res);
-				return res;
+				return Err(Error::TxSyncFailed);
 			},
 		}
 
@@ -400,20 +394,11 @@ impl BitcoindChainSource {
 		locked_node_metrics.latest_lightning_wallet_sync_timestamp = unix_time_secs_opt;
 		locked_node_metrics.latest_onchain_wallet_sync_timestamp = unix_time_secs_opt;
 
-		let write_res = write_node_metrics(
+		write_node_metrics(
 			&*locked_node_metrics,
 			Arc::clone(&self.kv_store),
 			Arc::clone(&self.logger),
-		);
-		match write_res {
-			Ok(()) => (),
-			Err(e) => {
-				log_error!(self.logger, "Failed to persist node metrics: {}", e);
-				let res = Err(Error::PersistenceFailed);
-				self.wallet_polling_status.lock().unwrap().propagate_result_to_subscribers(res);
-				return res;
-			},
-		}
+		)?;
 
 		Ok(())
 	}