Skip to content

Commit 2862208

Browse files
committed
Fix and run all tests under cfg(vss_test)
.. we previously avoided running some tests which turned out to be broken.
1 parent fad40b8 commit 2862208

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

.github/workflows/vss-integration.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,4 +44,4 @@ jobs:
4444
run: |
4545
cd ldk-node
4646
export TEST_VSS_BASE_URL="http://localhost:8080/vss"
47-
RUSTFLAGS="--cfg vss_test" cargo test --test integration_tests_vss
47+
RUSTFLAGS="--cfg vss_test" cargo test

src/io/vss_store.rs

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -581,38 +581,40 @@ mod tests {
581581

582582
use rand::distributions::Alphanumeric;
583583
use rand::{thread_rng, Rng, RngCore};
584-
use tokio::runtime;
585584
use vss_client::headers::FixedHeaders;
586585

587586
use super::*;
588587
use crate::io::test_utils::do_read_write_remove_list_persist;
588+
use crate::Logger;
589589

590590
#[test]
591591
fn vss_read_write_remove_list_persist() {
592-
let runtime = Arc::new(Runtime::new().unwrap());
592+
let logger = Arc::new(Logger::new_log_facade());
593+
let runtime = Arc::new(Runtime::new(logger).unwrap());
593594
let vss_base_url = std::env::var("TEST_VSS_BASE_URL").unwrap();
594595
let mut rng = thread_rng();
595596
let rand_store_id: String = (0..7).map(|_| rng.sample(Alphanumeric) as char).collect();
596597
let mut vss_seed = [0u8; 32];
597598
rng.fill_bytes(&mut vss_seed);
598599
let header_provider = Arc::new(FixedHeaders::new(HashMap::new()));
599600
let vss_store =
600-
VssStore::new(vss_base_url, rand_store_id, vss_seed, header_provider, runtime).unwrap();
601+
VssStore::new(vss_base_url, rand_store_id, vss_seed, header_provider, runtime);
601602

602603
do_read_write_remove_list_persist(&vss_store);
603604
}
604605

605606
#[tokio::test(flavor = "multi_thread", worker_threads = 1)]
606607
async fn vss_read_write_remove_list_persist_in_runtime_context() {
607-
let runtime = Arc::new(Runtime::new().unwrap());
608+
let logger = Arc::new(Logger::new_log_facade());
609+
let runtime = Arc::new(Runtime::new(logger).unwrap());
608610
let vss_base_url = std::env::var("TEST_VSS_BASE_URL").unwrap();
609611
let mut rng = thread_rng();
610612
let rand_store_id: String = (0..7).map(|_| rng.sample(Alphanumeric) as char).collect();
611613
let mut vss_seed = [0u8; 32];
612614
rng.fill_bytes(&mut vss_seed);
613615
let header_provider = Arc::new(FixedHeaders::new(HashMap::new()));
614616
let vss_store =
615-
VssStore::new(vss_base_url, rand_store_id, vss_seed, header_provider, runtime).unwrap();
617+
VssStore::new(vss_base_url, rand_store_id, vss_seed, header_provider, runtime);
616618

617619
do_read_write_remove_list_persist(&vss_store);
618620
drop(vss_store)

0 commit comments

Comments
 (0)