Use cancellable task for inbound connections

joostjager · joostjager · commit 2b09f98802f1 · 2025-09-22T18:11:36.000+02:00
So that we'll cleanly signal and wait for termination.
diff --git a/src/lib.rs b/src/lib.rs
@@ -325,6 +325,7 @@ impl Node {
 				bind_addrs.extend(resolved_address);
 			}
 
+			let runtime = Arc::clone(&self.runtime);
 			self.runtime.spawn_cancellable_background_task(async move {
 				{
 				let listener =
@@ -350,7 +351,7 @@ impl Node {
 						}
 						res = listener.accept() => {
 							let tcp_stream = res.unwrap().0;
-							tokio::spawn(async move {
+							runtime.spawn_cancellable_background_task(async move {
 								lightning_net_tokio::setup_inbound(
 									Arc::clone(&peer_mgr),
 									tcp_stream.into_std().unwrap(),

Original file line number	Diff line number	Diff line change
`@@ -325,6 +325,7 @@ impl Node {`
`325`	`325`	`bind_addrs.extend(resolved_address);`
`326`	`326`	`}`
`327`	`327`
	`328`	`+ let runtime = Arc::clone(&self.runtime);`
`328`	`329`	`self.runtime.spawn_cancellable_background_task(async move {`
`329`	`330`	`{`
`330`	`331`	`let listener =`
`@@ -350,7 +351,7 @@ impl Node {`
`350`	`351`	`}`
`351`	`352`	`res = listener.accept() => {`
`352`	`353`	`let tcp_stream = res.unwrap().0;`
`353`		`- tokio::spawn(async move {`
	`354`	`+ runtime.spawn_cancellable_background_task(async move {`
`354`	`355`	`lightning_net_tokio::setup_inbound(`
`355`	`356`	`Arc::clone(&peer_mgr),`
`356`	`357`	`tcp_stream.into_std().unwrap(),`