fixup! Add support for sending to human-readable names that resolve to Bolt12 Offers

Author: chuksys

bindings/ldk_node.udl

@@ -256,7 +256,7 @@ interface LSPS1Liquidity {
 };
 
 interface HumanReadableName {
-	[Name=from_encoded]
+	[Throws=NodeError, Name=from_encoded]
 	constructor([ByRef] string encoded);
 	string user();
 	string domain();

src/error.rs

@@ -123,7 +123,7 @@ pub enum Error {
 	/// Parsing a Human-Readable Name has failed
 	HrnParsingFailed,
 	/// The given operation failed due to `dns-resolvers` not being configured in builder.
-	DnsResolversNotConfigured,
+	DnsResolversUnavailable,
 }
 
 impl fmt::Display for Error {
@@ -200,7 +200,7 @@ impl fmt::Display for Error {
 			Self::HrnParsingFailed => {
 				write!(f, "Failed to parse a human-readable name.")
 			},
-			Self::DnsResolversNotConfigured => {
+			Self::DnsResolversUnavailable => {
 				write!(f, "The given operation failed due to `dns-resolvers` not being configured in builder.")
 			},
 		}

src/payment/bolt12.rs

@@ -280,6 +280,8 @@ impl Bolt12Payment {
 	/// amount paid to be determined by the user.
 	///
 	/// If `dns_resolvers_node_ids` in [`Config.hrn_config`] is empty, this operation will fail.
+	///
+	/// [BIP 353]: https://github.com/bitcoin/bips/blob/master/bip-0353.mediawiki
 	pub fn send_to_human_readable_name(
 		&self, hrn: HumanReadableName, amount_msat: u64,
 	) -> Result<PaymentId, Error> {
@@ -294,13 +296,14 @@ impl Bolt12Payment {
 		let retry_strategy = Retry::Timeout(LDK_PAYMENT_RETRY_TIMEOUT);
 		let max_total_routing_fee_msat = None;
 
-		let destinations: Vec<Destination> = self
-			.config
-			.hrn_config
-			.dns_resolvers_node_ids
-			.iter()
-			.map(|node_id| Destination::Node(*node_id))
-			.collect();
+		let destinations: Vec<Destination> = match &self.config.hrn_config {
+			Some(hrn_config) => Ok(hrn_config
+				.dns_resolvers_node_ids
+				.iter()
+				.map(|node_id| Destination::Node(*node_id))
+				.collect()),
+			None => Err(Error::DnsResolversUnavailable),
+		}?;
 
 		let hrn = maybe_convert_hrn(hrn);
 

src/uniffi_types.rs

@@ -667,13 +667,13 @@ impl HumanReadableName {
 		self.inner.clone()
 	}
 
-	pub fn from_encoded(encoded: &str) -> Self {
+	pub fn from_encoded(encoded: &str) -> Result<Self, Error> {
 		let hrn = match LdkHumanReadableName::from_encoded(encoded) {
 			Ok(hrn) => Ok(hrn),
-			Err(e) => Err(format!("Error creating HRN {:?}", e)),
-		};
+			Err(_) => Err(Error::HrnParsingFailed),
+		}?;
 
-		Self { inner: hrn.expect("Error creating HRN") }
+		Ok(Self { inner: hrn })
 	}
 
 	pub fn user(&self) -> String {