Add more debug_asserts for updating BOLT12 payment hashes

Author: tnull

src/payment/store.rs

@@ -85,6 +85,10 @@ impl PaymentDetails {
 						PaymentDirection::Outbound,
 						"We should only ever override payment hash for outbound BOLT 12 payments"
 					);
+					debug_assert!(
+						hash.is_none() || *hash == hash_opt,
+						"We should never change a payment hash after being initially set"
+					);
 					update_if_necessary!(*hash, hash_opt);
 				},
 				PaymentKind::Bolt12Refund { ref mut hash, .. } => {
@@ -93,6 +97,10 @@ impl PaymentDetails {
 						PaymentDirection::Outbound,
 						"We should only ever override payment hash for outbound BOLT 12 payments"
 					);
+					debug_assert!(
+						hash.is_none() || *hash == hash_opt,
+						"We should never change a payment hash after being initially set"
+					);
 					update_if_necessary!(*hash, hash_opt);
 				},
 				_ => {