Drop debug_assert that would have us panic for replayed PaymentClaimeds

In cd8958f we changed the internal API behavior of
`PaymentStore::update`. While previously it would return `Ok(true)` the
to-be-updated entry was found in the store, it now returns `Ok(true)` if
not only the entry was found but it was actually updated and
re-persisted. This was an improvement as it allows us to avoid
unnecessary re-persists if nothing changed.

However, there were 1-2 places that implicitly relied on that behavior
for logging purposes which we didn't correctly update to the new
behavior. Unfortunately, one instance in handling `PaymentClaimed`
events actually even `debug_assert`ed on the return value, which lead to
some unnecessary panics in `debug` in case `PaymentClaimed` got
replayed. Here we rectify this by dropping the `debug_assert`.

Author: tnull

src/event.rs

@@ -906,15 +906,7 @@ where
 				};
 
 				match self.payment_store.update(&update) {
-					Ok(true) => (),
-					Ok(false) => {
-						log_error!(
-							self.logger,
-							"Payment with ID {} couldn't be found in store",
-							payment_id,
-						);
-						debug_assert!(false);
-					},
+					Ok(_) => (),
 					Err(e) => {
 						log_error!(
 							self.logger,

src/payment/bolt11.rs

@@ -408,13 +408,25 @@ impl Bolt11Payment {
 			..PaymentDetailsUpdate::new(payment_id)
 		};
 
-		if !self.payment_store.update(&update)? {
-			log_error!(
-				self.logger,
-				"Failed to manually fail unknown payment with hash: {}",
-				payment_hash
-			);
-			return Err(Error::InvalidPaymentHash);
+		match self.payment_store.update(&update) {
+			Ok(true) => (),
+			Ok(false) => {
+				log_error!(
+					self.logger,
+					"Failed to manually fail unknown payment with hash {}",
+					payment_hash,
+				);
+				return Err(Error::InvalidPaymentHash);
+			},
+			Err(e) => {
+				log_error!(
+					self.logger,
+					"Failed to manually fail unknown payment with hash {}: {}",
+					payment_hash,
+					e
+				);
+				return Err(e);
+			},
 		}
 
 		self.channel_manager.fail_htlc_backwards(&payment_hash);