continue receive flow on offer/invoice creation failure

Author: Camillarhi

src/payment/unified_qr.rs

@@ -75,9 +75,12 @@ impl UnifiedQrPayment {
 	/// - `expiry_sec`: The expiration time for the payment, specified in seconds.
 	///
 	/// Returns a payable URI that can be used to request and receive a payment of the amount
-	/// given. In case of an error, the function returns `Error::WalletOperationFailed`for on-chain
-	/// address issues, `Error::InvoiceCreationFailed` for BOLT11 invoice issues, or
-	/// `Error::OfferCreationFailed` for BOLT12 offer issues.
+	/// given. The URI will almost always contain at least the on-chain address, and may additionally
+	/// contain a BOLT11 invoice and/or BOLT12 offer if they were successfully generated.
+	///
+	/// Errors during invoice or offer generation are logged but don't prevent the URI generation,
+	/// allowing for graceful degradation of functionality. Only complete failure to generate
+	/// the on-chain address will result in an error return (`Error::WalletOperationFailed`).
 	///
 	/// The generated URI can then be given to a QR code library.
 	///
@@ -95,7 +98,7 @@ impl UnifiedQrPayment {
 			Ok(offer) => Some(offer),
 			Err(e) => {
 				log_error!(self.logger, "Failed to create offer: {}", e);
-				return Err(Error::OfferCreationFailed);
+				None
 			},
 		};
 
@@ -111,7 +114,7 @@ impl UnifiedQrPayment {
 			Ok(invoice) => Some(invoice),
 			Err(e) => {
 				log_error!(self.logger, "Failed to create invoice {}", e);
-				return Err(Error::InvoiceCreationFailed);
+				None
 			},
 		};
 

tests/integration_tests_rust.rs

@@ -1083,6 +1083,22 @@ fn generate_bip21_uri() {
 	let address_a = node_a.onchain_payment().new_address().unwrap();
 	let premined_sats = 5_000_000;
 
+	let expected_amount_sats = 100_000;
+	let expiry_sec = 4_000;
+
+	// No channels exist yet
+	let initial_uqr_payment = node_b.unified_qr_payment().receive(expected_amount_sats, "asdf", expiry_sec);
+	
+	match initial_uqr_payment.clone() {
+		Ok(ref uri) => {
+			println!("Generated URI: {}", uri);
+			assert!(uri.contains("bitcoin:"));
+			assert!(uri.contains("lightning="));
+			assert!(!uri.contains("lno=")); // BOLT12 requires channels
+		},
+		Err(e) => panic!("Failed to generate URI: {:?}", e),
+	}
+
 	premine_and_distribute_funds(
 		&bitcoind.client,
 		&electrsd.client,
@@ -1100,9 +1116,6 @@ fn generate_bip21_uri() {
 	expect_channel_ready_event!(node_a, node_b.node_id());
 	expect_channel_ready_event!(node_b, node_a.node_id());
 
-	let expected_amount_sats = 100_000;
-	let expiry_sec = 4_000;
-
 	let uqr_payment = node_b.unified_qr_payment().receive(expected_amount_sats, "asdf", expiry_sec);
 
 	match uqr_payment.clone() {