refactor: change Result return type for infallible new_log_facade & new_custom_writer

Author: enigbe

src/builder.rs

@@ -1308,13 +1308,10 @@ fn setup_logger(config_opt: &Option<LogWriterConfig>) -> Result<Arc<Logger>, Bui
 			Logger::new_fs_writer(log_file_path, log_level)
 				.map_err(|_| BuildError::LoggerSetupFailed)?
 		},
-		LogWriterConfig::Log(log_level) => {
-			Logger::new_log_facade(*log_level).map_err(|_| BuildError::LoggerSetupFailed)?
-		},
+		LogWriterConfig::Log(log_level) => Logger::new_log_facade(*log_level),
 
 		LogWriterConfig::Custom(custom_log_writer) => {
 			Logger::new_custom_writer(Arc::clone(custom_log_writer))
-				.map_err(|_| BuildError::LoggerSetupFailed)?
 		},
 	};
 

src/logger.rs

@@ -181,12 +181,12 @@ impl Logger {
 		Ok(Self { writer: Writer::FileWriter { file_path: file_path.to_string(), level } })
 	}
 
-	pub fn new_log_facade(level: LogLevel) -> Result<Self, ()> {
-		Ok(Self { writer: Writer::LogFacadeWriter { level } })
+	pub fn new_log_facade(level: LogLevel) -> Self {
+		Self { writer: Writer::LogFacadeWriter { level } }
 	}
 
-	pub fn new_custom_writer(log_writer: Arc<dyn LogWriter + Send + Sync>) -> Result<Self, ()> {
-		Ok(Self { writer: Writer::CustomWriter(log_writer) })
+	pub fn new_custom_writer(log_writer: Arc<dyn LogWriter + Send + Sync>) -> Self {
+		Self { writer: Writer::CustomWriter(log_writer) }
 	}
 }