Skip to content

Commit 8ce139a

Browse files
committed
Improve logging in stop
.. we provide finer-grained logging after each step of `stop`.
1 parent 8f8d7e5 commit 8ce139a

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

src/lib.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -577,7 +577,6 @@ impl Node {
577577
})
578578
};
579579

580-
let background_stop_logger = Arc::clone(&self.logger);
581580
let handle = runtime.spawn(async move {
582581
process_events_async(
583582
background_persister,
@@ -598,7 +597,6 @@ impl Node {
598597
log_error!(background_error_logger, "Failed to process events: {}", e);
599598
panic!("Failed to process events");
600599
});
601-
log_debug!(background_stop_logger, "Events processing stopped.",);
602600
});
603601
debug_assert!(self.background_processor_task.lock().unwrap().is_none());
604602
*self.background_processor_task.lock().unwrap() = Some(handle);
@@ -644,7 +642,7 @@ impl Node {
644642

645643
// Stop the runtime.
646644
match self.stop_sender.send(()) {
647-
Ok(_) => (),
645+
Ok(_) => log_trace!(self.logger, "Sent shutdown signal to background tasks."),
648646
Err(e) => {
649647
log_error!(
650648
self.logger,
@@ -657,9 +655,11 @@ impl Node {
657655

658656
// Disconnect all peers.
659657
self.peer_manager.disconnect_all_peers();
658+
log_debug!(self.logger, "Disconnected all network peers.");
660659

661660
// Stop any runtime-dependant chain sources.
662661
self.chain_source.stop();
662+
log_debug!(self.logger, "Stopped chain sources.");
663663

664664
// Wait until background processing stopped, at least until a timeout is reached.
665665
if let Some(background_processor_task) =
@@ -678,7 +678,7 @@ impl Node {
678678

679679
match timeout_res {
680680
Ok(stop_res) => match stop_res {
681-
Ok(()) => {},
681+
Ok(()) => log_debug!(self.logger, "Stopped background processing of events."),
682682
Err(e) => {
683683
abort_handle.abort();
684684
log_error!(

0 commit comments

Comments
 (0)