f: drop is_listening and add test

Author: joostjager

bindings/ldk_node.udl

@@ -325,7 +325,6 @@ enum NodeError {
 
 dictionary NodeStatus {
 	boolean is_running;
-	boolean is_listening;
 	BestBlock current_best_block;
 	u64? latest_lightning_wallet_sync_timestamp;
 	u64? latest_onchain_wallet_sync_timestamp;

src/lib.rs

@@ -679,8 +679,6 @@ impl Node {
 	/// Returns the status of the [`Node`].
 	pub fn status(&self) -> NodeStatus {
 		let is_running = *self.is_running.read().unwrap();
-		let is_listening =
-			is_running && self.config.listening_addresses.as_ref().map_or(false, |v| !v.is_empty());
 		let current_best_block = self.channel_manager.current_best_block().into();
 		let locked_node_metrics = self.node_metrics.read().unwrap();
 		let latest_lightning_wallet_sync_timestamp =
@@ -698,7 +696,6 @@ impl Node {
 
 		NodeStatus {
 			is_running,
-			is_listening,
 			current_best_block,
 			latest_lightning_wallet_sync_timestamp,
 			latest_onchain_wallet_sync_timestamp,
@@ -1509,9 +1506,6 @@ impl Drop for Node {
 pub struct NodeStatus {
 	/// Indicates whether the [`Node`] is running.
 	pub is_running: bool,
-	/// Indicates whether the [`Node`] is listening for incoming connections on the addresses
-	/// configured via [`Config::listening_addresses`].
-	pub is_listening: bool,
 	/// The best block to which our Lightning wallet is currently synced.
 	pub current_best_block: BestBlock,
 	/// The timestamp, in seconds since start of the UNIX epoch, when we last successfully synced

tests/integration_tests_rust.rs

@@ -817,6 +817,21 @@ fn sign_verify_msg() {
 	assert!(node.verify_signature(msg, sig.as_str(), &pkey));
 }
 
+#[test]
+fn connection_multi_listen() {
+	let (_bitcoind, electrsd) = setup_bitcoind_and_electrsd();
+	let chain_source = TestChainSource::Esplora(&electrsd);
+	let (node_a, node_b) = setup_two_nodes(&chain_source, false, false, false);
+
+	let node_id_b = node_b.node_id();
+
+	let node_addrs_b = node_b.listening_addresses().unwrap();
+	for node_addr_b in &node_addrs_b {
+		node_a.connect(node_id_b, node_addr_b.clone(), false).unwrap();
+		node_a.disconnect(node_id_b).unwrap();
+	}
+}
+
 #[test]
 fn connection_restart_behavior() {
 	do_connection_restart_behavior(true);
@@ -832,8 +847,6 @@ fn do_connection_restart_behavior(persist: bool) {
 	let node_id_b = node_b.node_id();
 
 	let node_addr_b = node_b.listening_addresses().unwrap().first().unwrap().clone();
-	assert!(node_b.status().is_listening);
-
 	node_a.connect(node_id_b, node_addr_b, persist).unwrap();
 
 	let peer_details_a = node_a.list_peers().first().unwrap().clone();
@@ -882,7 +895,6 @@ fn concurrent_connections_succeed() {
 
 	let node_id_b = node_b.node_id();
 	let node_addr_b = node_b.listening_addresses().unwrap().first().unwrap().clone();
-	assert!(node_b.status().is_listening);
 
 	let mut handles = Vec::new();
 	for _ in 0..10 {