Drop default_cltv_expiry_delta

.. as it was used for spontaneous payments only and hence a bit
misleading.

We drop it for now and see if any users would complain. If so, it would
probably be sufficient for it to be an optional parameter on the
spontaneous payments methods.

Author: tnull

bindings/ldk_node.udl

@@ -8,7 +8,6 @@ dictionary Config {
 	string? log_dir_path;
 	Network network;
 	sequence<SocketAddress>? listening_addresses;
-	u32 default_cltv_expiry_delta;
 	u64 onchain_wallet_sync_interval_secs;
 	u64 wallet_sync_interval_secs;
 	u64 fee_rate_cache_update_interval_secs;

src/config.rs

@@ -12,7 +12,6 @@ use std::time::Duration;
 // Config defaults
 const DEFAULT_STORAGE_DIR_PATH: &str = "/tmp/ldk_node/";
 const DEFAULT_NETWORK: Network = Network::Bitcoin;
-const DEFAULT_CLTV_EXPIRY_DELTA: u32 = 144;
 const DEFAULT_BDK_WALLET_SYNC_INTERVAL_SECS: u64 = 80;
 const DEFAULT_LDK_WALLET_SYNC_INTERVAL_SECS: u64 = 30;
 const DEFAULT_FEE_RATE_CACHE_UPDATE_INTERVAL_SECS: u64 = 60 * 10;
@@ -105,8 +104,6 @@ pub struct Config {
 	pub network: Network,
 	/// The addresses on which the node will listen for incoming connections.
 	pub listening_addresses: Option<Vec<SocketAddress>>,
-	/// The default CLTV expiry delta to be used for payments.
-	pub default_cltv_expiry_delta: u32,
 	/// The time in-between background sync attempts of the onchain wallet, in seconds.
 	///
 	/// **Note:** A minimum of 10 seconds is always enforced.
@@ -168,7 +165,6 @@ impl Default for Config {
 			log_dir_path: None,
 			network: DEFAULT_NETWORK,
 			listening_addresses: None,
-			default_cltv_expiry_delta: DEFAULT_CLTV_EXPIRY_DELTA,
 			onchain_wallet_sync_interval_secs: DEFAULT_BDK_WALLET_SYNC_INTERVAL_SECS,
 			wallet_sync_interval_secs: DEFAULT_LDK_WALLET_SYNC_INTERVAL_SECS,
 			fee_rate_cache_update_interval_secs: DEFAULT_FEE_RATE_CACHE_UPDATE_INTERVAL_SECS,

src/payment/spontaneous.rs

@@ -18,6 +18,9 @@ use bitcoin::secp256k1::PublicKey;
 
 use std::sync::{Arc, RwLock};
 
+// The default `final_cltv_expiry_delta` we apply when not set.
+const LDK_DEFAULT_FINAL_CLTV_EXPIRY_DELTA: u32 = 144;
+
 /// A payment handler allowing to send spontaneous ("keysend") payments.
 ///
 /// Should be retrieved by calling [`Node::spontaneous_payment`].
@@ -68,7 +71,7 @@ impl SpontaneousPayment {
 		}
 
 		let mut route_params = RouteParameters::from_payment_params_and_value(
-			PaymentParameters::from_node_id(node_id, self.config.default_cltv_expiry_delta),
+			PaymentParameters::from_node_id(node_id, LDK_DEFAULT_FINAL_CLTV_EXPIRY_DELTA),
 			amount_msat,
 		);
 
@@ -153,13 +156,12 @@ impl SpontaneousPayment {
 		}
 
 		let liquidity_limit_multiplier = Some(self.config.probing_liquidity_limit_multiplier);
-		let cltv_expiry_delta = self.config.default_cltv_expiry_delta;
 
 		self.channel_manager
 			.send_spontaneous_preflight_probes(
 				node_id,
 				amount_msat,
-				cltv_expiry_delta,
+				LDK_DEFAULT_FINAL_CLTV_EXPIRY_DELTA,
 				liquidity_limit_multiplier,
 			)
 			.map_err(|e| {