refactor: remove default_log_* functions

Removes the default_log_* functions that were hitherto
public functions used to share private constants. These
constants (DEFAULT_LOG_LEVEL and the renamed
DEFAULT_LOG_FILE_PATH) have been made public instead.

Author: enigbe

src/builder.rs

@@ -7,8 +7,8 @@
 
 use crate::chain::{ChainSource, DEFAULT_ESPLORA_SERVER_URL};
 use crate::config::{
-	default_log_file_path, default_log_level, default_user_config, Config, EsploraSyncConfig,
-	FilesystemLoggerConfig, WALLET_KEYS_SEED_LEN,
+	default_user_config, Config, EsploraSyncConfig, FilesystemLoggerConfig, DEFAULT_LOG_FILE_PATH,
+	DEFAULT_LOG_LEVEL, WALLET_KEYS_SEED_LEN,
 };
 
 use crate::connection::ConnectionManager;
@@ -1295,9 +1295,9 @@ fn setup_logger(config: &LogWriterConfig) -> Result<Arc<Logger>, BuildError> {
 			let log_file_path = if let Some(fp) = &fs_logger_config.log_file_path {
 				fp
 			} else {
-				&default_log_file_path()
+				DEFAULT_LOG_FILE_PATH
 			};
-			let log_level = fs_logger_config.log_level.unwrap_or(default_log_level());
+			let log_level = fs_logger_config.log_level.unwrap_or(DEFAULT_LOG_LEVEL);
 
 			Ok(Arc::new(
 				Logger::new_fs_writer(log_file_path, log_level)

src/config.rs

@@ -29,8 +29,12 @@ const DEFAULT_LDK_WALLET_SYNC_INTERVAL_SECS: u64 = 30;
 const DEFAULT_FEE_RATE_CACHE_UPDATE_INTERVAL_SECS: u64 = 60 * 10;
 const DEFAULT_PROBING_LIQUIDITY_LIMIT_MULTIPLIER: u64 = 3;
 const DEFAULT_ANCHOR_PER_CHANNEL_RESERVE_SATS: u64 = 25_000;
-const DEFAULT_LOG_FILE_PATH: &'static str = "ldk_node.log";
-const DEFAULT_LOG_LEVEL: LogLevel = LogLevel::Debug;
+
+/// The default log level.
+pub const DEFAULT_LOG_LEVEL: LogLevel = LogLevel::Debug;
+
+/// The default log file path.
+pub const DEFAULT_LOG_FILE_PATH: &'static str = "/tmp/ldk_node/ldk_node.log";
 
 // The 'stop gap' parameter used by BDK's wallet sync. This seems to configure the threshold
 // number of derivation indexes after which BDK stops looking for new scripts belonging to the wallet.
@@ -436,8 +440,7 @@ pub struct FilesystemLoggerConfig {
 	///
 	/// This specifies the log file path if a destination other than the storage
 	/// directory, i.e. [`Config::storage_dir_path`], is preferred. If unconfigured,
-	/// defaults to [`DEFAULT_STORAGE_DIR_PATH`]/[`DEFAULT_LOG_FILE_PATH`], i.e.
-	/// `/tmp/ldk_node/ldk_node.log`
+	/// defaults to [`DEFAULT_LOG_FILE_PATH`]
 	pub log_file_path: Option<String>,
 	/// This specifies the log level.
 	///
@@ -447,19 +450,13 @@ pub struct FilesystemLoggerConfig {
 
 impl Default for FilesystemLoggerConfig {
 	fn default() -> Self {
-		let log_file_path = default_log_file_path();
-		Self { log_file_path: Some(log_file_path), log_level: Some(default_log_level()) }
+		Self {
+			log_file_path: Some(DEFAULT_LOG_FILE_PATH.to_string()),
+			log_level: Some(DEFAULT_LOG_LEVEL),
+		}
 	}
 }
 
-pub(crate) fn default_log_file_path() -> String {
-	format!("{}/{}", DEFAULT_STORAGE_DIR_PATH, DEFAULT_LOG_FILE_PATH)
-}
-
-pub(crate) fn default_log_level() -> LogLevel {
-	DEFAULT_LOG_LEVEL
-}
-
 #[cfg(test)]
 mod tests {
 	use std::str::FromStr;