f Nits

Author: tnull

src/lib.rs

@@ -87,7 +87,7 @@ use std::sync::atomic::{AtomicBool, Ordering};
 use std::sync::{Arc, Mutex, RwLock};
 use std::time::{Duration, Instant, SystemTime};
 
-// The used 'stop gap' parameter used by BDK's wallet sync. This seems to configure the threshold
+// The 'stop gap' parameter used by BDK's wallet sync. This seems to configure the threshold
 // number of blocks after which BDK stops looking for scripts belonging to the wallet.
 const BDK_CLIENT_STOP_GAP: usize = 20;
 
@@ -197,7 +197,7 @@ impl Builder {
 	pub fn build(&self) -> Node {
 		let config = Arc::new(self.config.clone());
 
-		let ldk_data_dir = format!("{}/ldk", &config.storage_dir_path.clone());
+		let ldk_data_dir = format!("{}/ldk", &config.storage_dir_path);
 		fs::create_dir_all(ldk_data_dir.clone()).expect("Failed to create LDK data directory");
 
 		let bdk_data_dir = format!("{}/bdk", config.storage_dir_path.clone());
@@ -342,7 +342,7 @@ impl Builder {
 		let channel_manager = Arc::new(channel_manager);
 
 		// Step 8: Give ChannelMonitors to ChainMonitor
-		for (_blockhash, channel_monitor) in channel_monitors.drain(..) {
+		for (_blockhash, channel_monitor) in channel_monitors.into_iter() {
 			let funding_outpoint = channel_monitor.get_funding_txo().0;
 			chain_monitor.watch_channel(funding_outpoint, channel_monitor);
 		}
@@ -361,7 +361,7 @@ impl Builder {
 			Arc::clone(&logger),
 			IgnoringMessageHandler {},
 		));
-		let ephemeral_bytes: [u8; 32] = rand::thread_rng().gen();
+		let ephemeral_bytes: [u8; 32] = keys_manager.get_secure_random_bytes();
 		let lightning_msg_handler = MessageHandler {
 			chan_handler: Arc::clone(&channel_manager),
 			route_handler: Arc::clone(&gossip_sync),