Merge pull request #669 from tnull/2025-10-nightly-rustfmt-followup

Nightly `rustfmt` follow-up

Author: tnull

.github/workflows/cron-weekly-rustfmt.yml

@@ -0,0 +1,28 @@
+name: Nightly rustfmt
+on:
+  schedule:
+    - cron: "0 0 * * 0" # runs weekly on Sunday at 00:00
+  workflow_dispatch: # allows manual triggering
+jobs:
+  format:
+    name: Nightly rustfmt
+    runs-on: ubuntu-24.04
+    steps:
+      - uses: actions/checkout@v5
+      - uses: dtolnay/rust-toolchain@nightly
+        with:
+          components: rustfmt
+      - name: Run Nightly rustfmt
+        # Run the formatter and manually remove trailing whitespace.
+        run: cargo +nightly fmt && git ls-files -- '*.rs' -z | xargs sed -E -i'' -e 's/[[:space:]]+$//'
+      - name: Get the current date
+        run: echo "date=$(date +'%Y-%m-%d')" >> $GITHUB_ENV
+      - name: Create Pull Request
+        uses: peter-evans/create-pull-request@v7
+        with:
+          author: Fmt Bot <[email protected]>
+          title: Automated nightly rustfmt (${{ env.date }})
+          body: |
+           Automated nightly `rustfmt` changes by [create-pull-request](https://github.com/peter-evans/create-pull-request) GitHub action
+          commit-message: ${{ env.date }} automated rustfmt nightly 
+          labels: rustfmt

Cargo.toml

@@ -5,6 +5,7 @@ authors = ["Elias Rohrer <[email protected]>"]
 homepage = "https://lightningdevkit.org/"
 license = "MIT OR Apache-2.0"
 edition = "2021"
+rust-version = "1.85"
 description = "A ready-to-go node implementation built using LDK."
 repository = "https://github.com/lightningdevkit/ldk-node/"
 readme = "README.md"

rust-toolchain.toml

@@ -5,7 +5,6 @@ use_field_init_shorthand = true
 max_width = 100
 match_block_trailing_comma = true
 format_code_in_doc_comments = true
-overflow_delimited_expr = true
 comment_width = 100
 format_macro_matchers = true
 group_imports = "StdExternalCrate"
@@ -17,3 +16,4 @@ style_edition = "2021"
 # TBD: do we want comment and string wrapping?
 #wrap_comments = true
 #format_strings = true
+#overflow_delimited_expr = true

rustfmt.toml

@@ -628,9 +628,10 @@ impl NodeBuilder {
 			derive_xprv(config, &seed_bytes, VSS_HARDENED_CHILD_INDEX, Arc::clone(&logger))?;
 
 		let lnurl_auth_xprv = vss_xprv
-			.derive_priv(&Secp256k1::new(), &[ChildNumber::Hardened {
-				index: VSS_LNURL_AUTH_HARDENED_CHILD_INDEX,
-			}])
+			.derive_priv(
+				&Secp256k1::new(),
+				&[ChildNumber::Hardened { index: VSS_LNURL_AUTH_HARDENED_CHILD_INDEX }],
+			)
 			.map_err(|e| {
 				log_error!(logger, "Failed to derive VSS secret: {}", e);
 				BuildError::KVStoreSetupFailed

src/builder.rs

@@ -701,10 +701,10 @@ impl BitcoindClient {
 		let num_blocks_json = serde_json::json!(num_blocks);
 		let estimation_mode_json = serde_json::json!(estimation_mode);
 		rpc_client
-			.call_method::<FeeResponse>("estimatesmartfee", &[
-				num_blocks_json,
-				estimation_mode_json,
-			])
+			.call_method::<FeeResponse>(
+				"estimatesmartfee",
+				&[num_blocks_json, estimation_mode_json],
+			)
 			.await
 			.map(|resp| resp.0)
 	}

src/chain/bitcoind.rs

@@ -271,10 +271,14 @@ mod tests {
 	}
 
 	fn blinded_path() -> BlindedMessagePath {
-		BlindedMessagePath::from_blinded_path(pubkey(40), pubkey(41), vec![
-			BlindedHop { blinded_node_id: pubkey(42), encrypted_payload: vec![0; 43] },
-			BlindedHop { blinded_node_id: pubkey(43), encrypted_payload: vec![0; 44] },
-		])
+		BlindedMessagePath::from_blinded_path(
+			pubkey(40),
+			pubkey(41),
+			vec![
+				BlindedHop { blinded_node_id: pubkey(42), encrypted_payload: vec![0; 43] },
+				BlindedHop { blinded_node_id: pubkey(43), encrypted_payload: vec![0; 44] },
+			],
+		)
 	}
 
 	fn pubkey(byte: u8) -> PublicKey {