Add comments clarifying that syncing methods shouldn't be used for RPC

Author: tnull

src/chain/mod.rs

@@ -387,6 +387,8 @@ impl ChainSource {
 		}
 	}
 
+	// Synchronize the onchain wallet via transaction-based protocols (i.e., Esplora, Electrum,
+	// etc.)
 	pub(crate) async fn sync_onchain_wallet(&self) -> Result<(), Error> {
 		match self {
 			Self::Esplora {
@@ -502,10 +504,16 @@ impl ChainSource {
 
 				res
 			},
-			Self::BitcoindRpc { .. } => todo!(),
+			Self::BitcoindRpc { .. } => {
+				// In BitcoindRpc mode we sync lightning and onchain wallet in one go by via
+				// `ChainPoller`. So nothing to do here.
+				unreachable!("Onchain wallet will be synced via chain polling")
+			},
 		}
 	}
 
+	// Synchronize the Lightning wallet via transaction-based protocols (i.e., Esplora, Electrum,
+	// etc.)
 	pub(crate) async fn sync_lightning_wallet(
 		&self, channel_manager: Arc<ChannelManager>, chain_monitor: Arc<ChainMonitor>,
 		output_sweeper: Arc<Sweeper>,
@@ -595,7 +603,11 @@ impl ChainSource {
 
 				res
 			},
-			Self::BitcoindRpc { .. } => todo!(),
+			Self::BitcoindRpc { .. } => {
+				// In BitcoindRpc mode we sync lightning and onchain wallet in one go by via
+				// `ChainPoller`. So nothing to do here.
+				unreachable!("Lightning wallet will be synced via chain polling")
+			},
 		}
 	}