f debug_assert we only allow skimmed_fees for JIT payments

tnull · tnull · commit fcacaeaf1806 · 2025-03-25T13:13:56.000+01:00
diff --git a/src/payment/store.rs b/src/payment/store.rs
@@ -170,7 +170,10 @@ impl PaymentDetails {
 				PaymentKind::Bolt11Jit { ref mut counterparty_skimmed_fee_msat, .. } => {
 					update_if_necessary!(*counterparty_skimmed_fee_msat, skimmed_fee_msat);
 				},
-				_ => {},
+				_ => debug_assert!(
+					false,
+					"We should only ever override counterparty_skimmed_fee_msat for JIT payments"
+				),
 			}
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -170,7 +170,10 @@ impl PaymentDetails {`
`170`	`170`	`PaymentKind::Bolt11Jit { ref mut counterparty_skimmed_fee_msat, .. } => {`
`171`	`171`	`update_if_necessary!(*counterparty_skimmed_fee_msat, skimmed_fee_msat);`
`172`	`172`	`},`
`173`		`- _ => {},`
	`173`	`+ _ => debug_assert!(`
	`174`	`+ false,`
	`175`	`+ "We should only ever override counterparty_skimmed_fee_msat for JIT payments"`
	`176`	`+ ),`
`174`	`177`	`}`
`175`	`178`	`}`
`176`	`179`