Add notes and questions for PR 2289

Author: dunxen

_posts/2023-06-20-#2289.md

@@ -5,16 +5,28 @@ title: "Create Taproot feature and introduce signer type enum"
 pr: 2289
 authors: [arik-so]
 components: ["channel", "sign"]
-host: dunxen
+host: vladimirfomene
 status: upcoming
 commit:
 ---
 
-_Notes and questions to follow soon!_
-
-<!-- TODO: Before meeting, add notes and questions
 ## Notes
+* [Simple Taproot Channels] is a proposal - in the form of an Extension BOLT to BOLTs 2, 3, and 5 - that aims to upgrade the funding and commitment design
+  of (V1 established) Lightning channels by using [BIP 327] MuSig2, an n-of-n multisignature scheme with [BIP 340] Schnorr signatures.
+  In the case of Lightning, this is currently and specifically 2-of-2.
+* The most obvious change for Simple Taproot Channels is the funding output being a **P2TR** instead of the currently used **P2WSH**. In a cooperative close,
+  and considering a large enough anonymity set, this would improve privacy as the close will just resemble a single-sig key-path spend.
+* LDK PR 2289 defines the feature bits for `option_taproot` in the appropriate feature contexts.
 
 ## Questions
-1. Did you review the PR? [Concept ACK, approach ACK, tested ACK, or NACK](https://github.com/lightningdevkit/rust-lightning/blob/master/CONTRIBUTING.md#peer-review)?
--->
+1. Did you review the PR? [Concept ACK, approach ACK](https://github.com/lightningdevkit/rust-lightning/blob/master/CONTRIBUTING.md#peer-review)?
+1. Why do Lightning features always reserve a pair of bits when defined?
+1. **Open question**: Why is it helpful to just define the `option_taproot` feature in LDK at this point in time? Alternatively, why is there no harm in doing so?
+1. Which feature bit pair is reserved for `option_taproot`? In which *contexts* can this feature appear?
+1. For each feature context mentioned before, can you explain why the feature is relevant to that context (what it's used for)?
+1. Which of the specified contexts are not currently relevant to Simple Taproot Channels and why?
+1. What does the `ChannelSignerType` describe and why is it introduced?
+
+[Simple Taproot Channels]: https://github.com/lightning/bolts/blob/e95e7acbda14e07fa53c1389f952481b822db795/bolt-simple-taproot.md
+[BIP 340]: https://bips.xyz/340
+[BIP 327]: https://bips.xyz/327