Merge pull request #21 from dunxen/add-2495

Author: dunxen

Rakefile

@@ -93,8 +93,8 @@ namespace :posts do
 
     # Set default value for meeting date if not supplied by user.
     unless date
-      date = next_wednesday.to_s
-      puts "Date set to next Wednesday: #{date}"
+      date = next_friday.to_s
+      puts "Date set to next Friday: #{date}"
     end
 
     # Ensure meeting date is valid.
@@ -156,8 +156,8 @@ def valid_iso8601_date?(date_string)
     yyyy >= Date.today.year && Date.valid_date?(yyyy, mm, dd)
 end
 
-def next_wednesday(date = Date.today, wednesday = 3)
-  date + ((wednesday - date.wday) % 7)
+def next_friday(date = Date.today, friday = 5)
+  date + ((friday - date.wday) % 7)
 end
 
 def parse_response(http, pr)

_config.yml

@@ -13,7 +13,7 @@ author:            "LDK PR Review Club contributors"
 coordinator:       "LDK contributor [dunxen](https://github.com/dunxen)"
 coordinator_irc:   "dunxen"
 description:       "A fortnightly review club for LDK PRs"
-meeting_day:       "Tuesday"
+meeting_day:       "Friday"
 meeting_location:  'the #review-club channel on <a href="https://discord.gg/5AcknnMfBw">our Discord server</a>'
 meeting_time:      "18:00 UTC"
 title:             "LDK PR Review Club"

_posts/2023-08-04-#2428.md

@@ -6,7 +6,7 @@ pr: 2428
 authors: [waterson]
 components: ["channel", "ChannelManager"]
 host: dunxen
-status: upcoming
+status: past
 commit:
 ---
 

_posts/2023-08-18-#2495.md

@@ -0,0 +1,27 @@
+---
+layout: pr
+date: 2023-08-18
+title: "Use a single peer state map for all channel phases in peer state"
+pr: 2495
+authors: [dunxen]
+components: ["channel", "ChannelPhase", "ChannelManager", "PeerState"]
+host: dunxen
+status: upcoming
+commit:
+---
+
+## Notes
+* PR 2495 introduces the `ChannelPhase` enum with variants containing each existing channel struct so that they can be placed in a single map in `PeerState`.
+* This was one possible design considered during the conceptual review of the `Channel` split and refactoring work, but seemed to introduce too much complexity at the time
+  when combined with the `ChannelInterface` type that was considered earlier but later dropped. At this stage it makes sense to take another look at using an enum map going forward
+  to address some short-comings of the existing (however simple) multi-map approach for `PeerState` channels - one issue being higher order map lookups in a few cases.
+
+## Questions
+1. Did you review the PR? [Concept ACK, approach ACK, tested ACK, or NACK](https://github.com/lightningdevkit/rust-lightning/blob/master/CONTRIBUTING.md#peer-review)?
+1. What are the advantages of having a single map for unfunded and funded channel types per peer? What are the disadvantages?
+1. We still want different types to differentiate between different unfunded and funded channels, how do we manage to have three different channel types
+   in a single `HashMap`?
+1. We'd like to introduce a proper type for channel IDs in LDK, as seen in [PR 2485](https://github.com/lightningdevkit/rust-lightning/pull/2485). If we further differentiate
+   between channel types, such as having separate types for random V1 `temporary_channel_id`'s, txid-based V1 `channel_id`s, zero-XORed V2 `temporary_channel_id`s, and XORed V2 `channel_id`s,
+   how would we handle this for keys, or is it best to stick to just using plain `[u8; 32]`s in the `channel_by_id` map?
+1. What is the current phase of the moon? Please only answer with an emoji.

hosting.md

@@ -91,7 +91,7 @@ rake posts:new -- -p PR_NUMBER -h HOST_USERNAME -d YYYY-MM-DD
 
 The `-p` (`pr`)  and `-h` (`host`) arguments are required. The `-d` (`date`)
 argument is optional; if no date is passed the meeting date will be set by default
-to next Tuesday.
+to next Friday.
 
 The `host` argument is your GitHub username.
 

index.md

@@ -5,7 +5,7 @@ title: home
 ### A fortnightly review club for Lightning Dev Kit (LDK) PRs
 
 <span class="question">What is this?</span> &nbsp;A fortnightly club for reviewing
-LDK PRs at **{{ site.meeting_time }} usually every second {{ site.meeting_day }}** in
+LDK PRs at **{{ site.meeting_time }} every second {{ site.meeting_day }}** in
 {{ site.meeting_location }}.
 
 <span class="question">What's it for?</span> &nbsp;To help newer contributors