Skip to content

Commit f100b0b

Browse files
committed
Add notes and first few questions
1 parent 4c668ae commit f100b0b

File tree

2 files changed

+15
-9
lines changed

2 files changed

+15
-9
lines changed

_config.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ sass:
1010

1111
# Site settings
1212
author: "LDK PR Review Club contributors"
13-
coordinator: "LDK contributor [ariard](https://github.com/ariard)"
14-
coordinator_irc: "ariard"
13+
coordinator: "LDK contributor [dunxen](https://github.com/dunxen)"
14+
coordinator_irc: "dunxen"
1515
description: "A fortnightly review club for LDK PRs"
1616
meeting_day: "Tuesday"
1717
meeting_location: 'the #review-club channel on <a href="https://discord.gg/5AcknnMfBw">our Discord server</a>'

_posts/2023-04-11-#2089.md

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
---
22
layout: pr
3-
date: 2023-04-11
3+
date: 2023-04-13
44
title: "Add BumpTransaction event handler"
55
pr: 2089
66
authors: [wpaulino]
@@ -12,12 +12,18 @@ commit:
1212

1313
_Notes and questions to follow soon!_
1414

15-
<!-- TODO: Before meeting, add notes and questions
1615
## Notes
16+
* PR2089 make it easy for users of LDK to be able to bump the fees of their local commitment and HTLC transactions
17+
thanks to anchor outputs and [Child-Pays-For-Parent](https://bitcoinops.org/en/topics/cpfp) (CPFP) fee-bumping.
18+
* An event handler for the `BumpTransactionEvent` is introduced covering the cases of a pending unilateral close and
19+
HTLC resolution with the `ChannelClose` and `HTLCResolution` event variants respectively.
1720

1821
## Questions
19-
1. Did you review the PR? [Concept ACK, approach ACK, tested ACK, or NACK](https://github.com/lightningdevkit/rust-lightning/blob/master/CONTRIBUTING.md#peer-review)?
20-
-->
21-
22-
23-
-->
22+
1. Did you review the PR? Concept ACK, approach ACK, or NACK?
23+
1. On which two objects are `Event`s exposed to a user of LDK? What convenience object does LDK provide to ensure that
24+
these events get processed periodically and how does a user specify the action taken for each event?
25+
1. Users need to implement one of two `trait`s in order for LDK to make use of their confirmed UTXOs for fee-bumping
26+
in the `BumpTransactionEventHandler`. What are these two traits and what are the differences between them?
27+
1. What strategy is proposed for LDK to use for coin selection when it is required to do so for fee-bumping? What are some
28+
other strategies for coin selection that exist? Are they worth consideration?
29+
1. What's the purpose of exposing `pending_htlcs` in `BumpTransactionEvent::ChannelClose`?

0 commit comments

Comments
 (0)