Skip to content

Commit 404936b

Browse files
committed
Fix tests to work with 0.0.14
1 parent 566c772 commit 404936b

File tree

5 files changed

+22
-12
lines changed

5 files changed

+22
-12
lines changed

ci/Dockerfile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,4 +45,5 @@ ENV LLVM_CLANG_ASAN_PATH="/clang+llvm-11.0.0-x86_64-linux-gnu-ubuntu-20.04/lib/c
4545
ENV ASAN_SYMBOLIZER_PATH="/clang+llvm-11.0.0-x86_64-linux-gnu-ubuntu-20.04/bin/llvm-symbolizer"
4646
ENV PATH="/clang+llvm-11.0.0-x86_64-linux-gnu-ubuntu-20.04/bin:${PATH}"
4747
ENV RUST_BACKTRACE=1
48+
ENV RUSTFLAGS="--cfg=c_bindings"
4849
ENV SHELL=/bin/bash

ci/LDKSwift/Tests/LDKSwiftTests/HumanObjectPeerTestInstance.swift

Lines changed: 13 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -123,11 +123,11 @@ public class HumanObjectPeerTestInstance {
123123
}
124124

125125
fileprivate class TestPersister: Persist {
126-
override func persist_new_channel(id: OutPoint, data: ChannelMonitor) -> Result_NoneChannelMonitorUpdateErrZ {
126+
override func persist_new_channel(channel_id: OutPoint, data: ChannelMonitor, update_id: MonitorUpdateId) -> Result_NoneChannelMonitorUpdateErrZ {
127127
return Result_NoneChannelMonitorUpdateErrZ.ok()
128128
}
129129

130-
override func update_persisted_channel(id: OutPoint, update: ChannelMonitorUpdate, data: ChannelMonitor) -> Result_NoneChannelMonitorUpdateErrZ {
130+
override func update_persisted_channel(channel_id: OutPoint, update: ChannelMonitorUpdate, data: ChannelMonitor, update_id: MonitorUpdateId) -> Result_NoneChannelMonitorUpdateErrZ {
131131
return Result_NoneChannelMonitorUpdateErrZ.ok()
132132
}
133133
}
@@ -180,8 +180,14 @@ public class HumanObjectPeerTestInstance {
180180
self.init(master: master, _dummy: (), seed: seed)
181181

182182
if master.use_chan_manager_constructor {
183-
self.constructor = ChannelManagerConstructor(network: LDKNetwork_Bitcoin, config: UserConfig(), current_blockchain_tip_hash: [UInt8](repeating: 0, count: 32), current_blockchain_tip_height: 0, keys_interface: self.keysInterface, fee_estimator: self.feeEstimator, chain_monitor: self.chainMonitor!, router: self.router, tx_broadcaster: self.txBroadcaster, logger: self.logger)
184-
self.constructor?.chain_sync_completed(persister: TestChannelManagerPersister(master: self))
183+
184+
let graph = NetworkGraph(genesis_hash: [UInt8](repeating: 0, count: 32))
185+
self.constructor = ChannelManagerConstructor(network: LDKNetwork_Bitcoin, config: UserConfig(), current_blockchain_tip_hash: [UInt8](repeating: 0, count: 32), current_blockchain_tip_height: 0, keys_interface: self.keysInterface, fee_estimator: self.feeEstimator, chain_monitor: self.chainMonitor!, net_graph: graph, tx_broadcaster: self.txBroadcaster, logger: self.logger)
186+
187+
// self.constructor = ChannelManagerConstructor(network: LDKNetwork_Bitcoin, config: UserConfig(), current_blockchain_tip_hash: [UInt8](repeating: 0, count: 32), current_blockchain_tip_height: 0, keys_interface: self.keysInterface, fee_estimator: self.feeEstimator, chain_monitor: self.chainMonitor!, net_graph: nil, tx_broadcaster: self.txBroadcaster, logger: self.logger)
188+
189+
190+
self.constructor?.chain_sync_completed(persister: TestChannelManagerPersister(master: self), scorer: nil)
185191
self.channelManager = self.constructor!.channelManager
186192
self.peerManager = self.constructor!.peerManager
187193
} else {
@@ -199,8 +205,9 @@ public class HumanObjectPeerTestInstance {
199205
self.init(master: original.master, _dummy: (), seed: original.seed)
200206

201207
if master.use_chan_manager_constructor {
202-
self.constructor = ChannelManagerConstructor(network: LDKNetwork_Bitcoin, config: UserConfig(), current_blockchain_tip_hash: [UInt8](repeating: 0, count: 32), current_blockchain_tip_height: 0, keys_interface: self.keysInterface, fee_estimator: self.feeEstimator, chain_monitor: self.chainMonitor!, router: self.router, tx_broadcaster: self.txBroadcaster, logger: self.logger)
203-
self.constructor?.chain_sync_completed(persister: TestChannelManagerPersister(master: self))
208+
let graph = NetworkGraph(genesis_hash: [UInt8](repeating: 0, count: 32))
209+
self.constructor = ChannelManagerConstructor(network: LDKNetwork_Bitcoin, config: UserConfig(), current_blockchain_tip_hash: [UInt8](repeating: 0, count: 32), current_blockchain_tip_height: 0, keys_interface: self.keysInterface, fee_estimator: self.feeEstimator, chain_monitor: self.chainMonitor!, net_graph: graph, tx_broadcaster: self.txBroadcaster, logger: self.logger)
210+
self.constructor?.chain_sync_completed(persister: TestChannelManagerPersister(master: self), scorer: nil)
204211
self.channelManager = self.constructor!.channelManager
205212
self.peerManager = self.constructor!.peerManager
206213
self.pendingManagerEvents.append(contentsOf: original.pendingManagerEvents)

ci/LDKSwift/Tests/LDKSwiftTests/LDKSwiftTest.swift

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ class LDKSwiftTest: XCTestCase {
6363
fee_estimator: feeEstimator,
6464
chain_monitor: chainMonitor,
6565
filter: filter,
66-
router: nil,
66+
net_graph: nil,
6767
tx_broadcaster: broadcaster,
6868
logger: logger
6969
)
@@ -75,7 +75,7 @@ class LDKSwiftTest: XCTestCase {
7575
let header = Self.hexStringToBytes(hexString: "f5591ea0b69ae3edc0de11497ffb0fdd91f769ede96c5d662c805364e9bf8b2243e8e5b9d1833eff7cb19abd9fc9da3cd26fe84d718bbf8a336966ae4f7dea6a81372961ffff7f200400000001020000")
7676
channel_manager.as_Confirm().transactions_confirmed(header: header, txdata: txdata, height: 525)
7777

78-
channel_manager_constructor.chain_sync_completed(persister: cmPersister)
78+
channel_manager_constructor.chain_sync_completed(persister: cmPersister, scorer: nil)
7979
channel_manager_constructor.interrupt()
8080
}
8181

@@ -114,7 +114,8 @@ class LDKSwiftTest: XCTestCase {
114114
path.append(extraHop)
115115
}
116116

117-
let route = Route(paths_arg: [path])
117+
let payee = Payee(pubkey: Self.hexStringToBytes(hexString: destPubkeyHex)!)
118+
let route = Route(paths_arg: [path], payee_arg: payee)
118119
}
119120

120121
func testExtendedActivity() throws {

ci/LDKSwift/Tests/LDKSwiftTests/TestLogger.swift

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ import LDKHeaders
1010

1111
class TestLogger: Logger {
1212

13-
override func log(record: String?) {
14-
print("record: \(record)")
15-
}
13+
override func log(record: Record) {
14+
print("some abstract log thing")
15+
}
1616

1717
}

ci/run_tests.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ find ./LDKSwift/Sources/LDKSwift/* -maxdepth 0 -not -name 'batteries' | xargs -r
99

1010
# build the bindings
1111
pushd /ldk-c-bindings/lightning-c-bindings
12+
export RUSTFLAGS="--cfg=c_bindings"
1213
cargo build
1314
popd
1415

0 commit comments

Comments
 (0)