Rename workflows and jobs, and canonicalize xcframework generation inside an action for easier reuse for releases.

Author: arik-so

.github/actions/generate-xcframework/action.yml

@@ -0,0 +1,13 @@
+name: Generate XCFramework
+description: Build xcarchives and combine them into an xcframework using Python scripts..
+runs:
+    using: composite
+    steps:
+        -   name: Build binaries
+            shell: bash
+            run:
+                python3 ./src/scripts/build_bulk_libldks.py
+        -   name: Generate xcframework
+            shell: bash
+            run:
+                python3 ./src/scripts/generate_xcframework.py

.github/workflows/build-frameworks.yml

@@ -1,4 +1,4 @@
-name: Build Frameworks
+name: Xcode Builds
 permissions:
     contents: read
     statuses: read
@@ -15,7 +15,7 @@ on:
 
 jobs:
     build:
-        name: Build Framework (${{ matrix.configuration['platform'] }})
+        name: Build XCArchive for ${{ matrix.configuration['platform'] }}
         runs-on: macos-12
         strategy:
             fail-fast: false
@@ -57,3 +57,20 @@ jobs:
                     project: ${{ matrix.configuration['project'] }}
                     scheme: ${{ matrix.configuration['scheme'] }}
                     destination: ${{ matrix.configuration['destination'] }}
+    generate:
+        name: Generate XCFramework
+        runs-on: macos-12
+        env:
+            DEVELOPER_DIR: /Applications/Xcode_13.2.1.app/Contents/Developer
+            LDK_C_BINDINGS_BASE: /Users/runner/work/ldk-swift/ldk-swift/bindings/artifacts/ldk-c-bindings
+        steps:
+            -   name: Configure Xcode
+                uses: maxim-lobanov/setup-xcode@v1
+                with:
+                    xcode-version: latest
+            -   name: Checkout
+                uses: actions/checkout@v2
+            -   name: Install Dependencies
+                uses: ./.github/actions/install-dependencies
+            -   name: Generate XCFramework
+                uses: ./.github/actions/generate-xcframework

.github/workflows/generate-xcframework.yml

@@ -1,4 +1,4 @@
-name: Check Bindings
+name: Test Bindings
 
 on:
     push:
@@ -8,7 +8,7 @@ on:
 
 jobs:
     check_bindings:
-        name: Build Bindings
+        name: Swift Package Manager Tests
         runs-on: ubuntu-20.04
         env:
             TOOLCHAIN: stable

.github/workflows/swift.yml

@@ -81,7 +81,7 @@ def run(config: ScriptConfig):
 				'BUILD_LIBRARY_FOR_DISTRIBUTION=YES',
 				f'LDK_C_BINDINGS_BASE={config.LDK_C_BINDINGS_BASE}',
 				f'LDK_C_BINDINGS_BINARY_DIRECTORY={lipo_binary_directory}',
-				f'LDK_C_BINDINGS_BINARY_FORCED_REBUILD_OUTPUT_DIRECTORY=""',
+				f'LDK_C_BINDINGS_BINARY_FORCED_REBUILD_OUTPUT_DIRECTORY=',
 			], env=child_environment
 		)