Fix generate_xcframework.py bug that broke loop instead of continuing when preserving xcarchives.

Author: arik-so

.github/actions/archive-framework/action.yml

@@ -17,12 +17,12 @@ runs:
 
                 LDK_C_BINDINGS_BINARY_DIRECTORY="" \
                 xcodebuild archive \
-                  -scheme 'LDKFramework' \
                   -project 'LDKFramework/LDKFramework.xcodeproj' \
-                  -destination '${{ inputs.destination }}' \
+                  -scheme 'LDKFramework' \
+                  -destination 'generic/platform=${{ inputs.destination }}' \
                   -archivePath "/Users/runner/work/ldk-swift/ldk-swift/bindings/bin/release/${{ inputs.human_readable_platform }}/${{ inputs.human_readable_platform }}" \
                   ENABLE_BITCODE=NO \
-                  CLANG_ADDRESS_SANITIZER=NO CLANG_ADDRESS_SANITIZER_ALLOW_ERROR_RECOVERY=NO CLANG_ADDRESS_SANITIZER_USE_AFTER_SCOPE=NO \
+                  EXCLUDED_ARCHS="i386 armv7" \
                   SKIP_INSTALL=NO BUILD_LIBRARY_FOR_DISTRIBUTION=YES \
                   LDK_C_BINDINGS_BASE="${LDK_C_BINDINGS_BASE}" \
                   LDK_C_BINDINGS_BINARY_DIRECTORY="" \

.github/workflows/build-xcframework-parallel-archives.yml

@@ -21,13 +21,13 @@ jobs:
             fail-fast: false
             matrix:
                 configuration:
-                    -   destination: generic/platform=iOS
-                        human_readable_platform: 'iphoneos'
-                    -   destination: platform=iOS Simulator,OS=15.2,name=iPhone 13 Pro
+                    -   destination: 'iOS Simulator'
                         human_readable_platform: 'iphonesimulator'
-                    -   destination: generic/platform=OS X
+                    -   destination: 'iOS'
+                        human_readable_platform: 'iphoneos'
+                    -   destination: 'OS X'
                         human_readable_platform: 'macosx'
-                    -   destination: platform=macOS,variant=Mac Catalyst,arch=x86_64
+                    -   destination: 'macOS,variant=Mac Catalyst'
                         human_readable_platform: 'catalyst'
         env:
             DEVELOPER_DIR: /Applications/Xcode_13.2.1.app/Contents/Developer
@@ -84,5 +84,5 @@ jobs:
             -   name: Upload Framework Artifact
                 uses: actions/upload-artifact@v3
                 with:
-                    name: LDKFramework.xcframework.zip
+                    name: LDKFramework
                     path: LDKFramework.xcframework.zip

.github/workflows/build-xcframework-parallel-libldk.yml

@@ -98,5 +98,5 @@ jobs:
             -   name: Upload Framework Artifact
                 uses: actions/upload-artifact@v3
                 with:
-                    name: LDKFramework.xcframework.zip
+                    name: LDKFramework
                     path: LDKFramework.xcframework.zip

.github/workflows/build-xcframework-sequential.yml

@@ -37,5 +37,5 @@ jobs:
             -   name: Upload Framework Artifact
                 uses: actions/upload-artifact@v3
                 with:
-                    name: LDKFramework.xcframework.zip
+                    name: LDKFramework
                     path: LDKFramework.xcframework.zip

src/scripts/generate_xcframework.py

@@ -65,7 +65,7 @@ def run(config: ScriptConfig):
 
 		if config.PRESERVE_XCARCHIVES:
 			# we don't regenerate any new xcarchives, and simply reuse the existing ones
-			break
+			continue
 
 		# create clean derived data directory
 		if os.path.exists(derived_data_directory):