Skip to content

Commit 6fa058f

Browse files
committed
Touch up README.md
1 parent 5c40d4a commit 6fa058f

File tree

1 file changed

+9
-8
lines changed

1 file changed

+9
-8
lines changed

README.md

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ from scratch.
1515
### Prerequisites
1616

1717
- A machine running macOS
18-
- Xcode 13.2.1 or lower (this is because there is a bug with `cc` that prevents it from compiling for Mac Catalyst targets with clang 13)
18+
- [Xcode 13.2.1](https://xcodereleases.com/) or lower (this is because there is a bug with `cc` that prevents it from compiling for Mac Catalyst targets with clang 13)
1919
- [Python3](https://programwithus.com/learn/python/install-python3-mac)
2020
- [Rust](https://www.rust-lang.org/tools/install)
2121
- [GNU sed](https://formulae.brew.sh/formula/gnu-sed) (optional, but will cut your compile times significantly!)
@@ -36,13 +36,13 @@ In order to generate these bindings from scratch, you will need to clone two dep
3636
**[rust-lightning](https://github.com/lightningdevkit/rust-lightning)**, (a specific branch built for bindings compatibility):
3737

3838
```shell
39-
git clone --branch 2022-06-108-java-bindings https://github.com/TheBlueMatt/rust-lightning /path/to/rust-lightning
39+
git clone --branch 2022-07-109-java-bindings https://github.com/TheBlueMatt/rust-lightning /path/to/rust-lightning
4040
```
4141

4242
**[ldk-c-bindings](https://github.com/lightningdevkit/ldk-c-bindings)**:
4343

4444
```shell
45-
git clone --branch v0.0.108.2 https://github.com/lightningdevkit/ldk-c-bindings /path/to/ldk-c-bindings
45+
git clone --branch v0.0.109.0 https://github.com/lightningdevkit/ldk-c-bindings /path/to/ldk-c-bindings
4646
```
4747

4848
Take note of where you clone these directories, it's best you save the absolute path somewhere handy for the rest of the remaining steps.
@@ -73,10 +73,11 @@ folder due to the previous `genbindings.sh` step. As Docker won't have access to
7373
replace those lines with the following:
7474

7575
```yaml
76-
lightning = { git = "https://github.com/thebluematt/rust-lightning", branch = "2021-03-java-bindings-base", default-features = false }
77-
lightning-persister = { git = "https://github.com/thebluematt/rust-lightning", branch = "2021-03-java-bindings-base", default-features = false }
78-
lightning-invoice = { git = "https://github.com/thebluematt/rust-lightning", branch = "2021-03-java-bindings-base", default-features = false }
79-
lightning-background-processor = { git = "https://github.com/thebluematt/rust-lightning", branch = "2021-03-java-bindings-base", default-features = false }
76+
lightning = { git = "https://github.com/thebluematt/rust-lightning", branch = "2022-07-109-java-bindings", default-features = false }
77+
lightning-persister = { git = "https://github.com/thebluematt/rust-lightning", branch = "2022-07-109-java-bindings", default-features = false }
78+
lightning-invoice = { git = "https://github.com/thebluematt/rust-lightning", branch = "2022-07-109-java-bindings", default-features = false }
79+
lightning-background-processor = { git = "https://github.com/thebluematt/rust-lightning", branch = "2022-07-109-java-bindings", default-features = false }
80+
lightning-rapid-gossip-sync = { git = "https://github.com/thebluematt/rust-lightning", branch = "2022-07-109-java-bindings", default-features = false }
8081
```
8182

8283
You will note that the revision is unspecified and is currently just placeholder `xxx`s. To obtain the revision,
@@ -136,7 +137,7 @@ Each of those folders will contain an `architectures` directory with subdirector
136137
or `x86_64`, as well as a `libldk.a` file, which is the `lipo` product of all the targeted
137138
architectures.
138139

139-
#### Generating the \*.xcframework files
140+
### Generating the \*.xcframework files
140141

141142
With all the binaries generated, still in the `./src/scripts` directory, you just need to run one
142143
last Python script to produce the framework:

0 commit comments

Comments
 (0)