Make address sanitizer only present if the env variable is set, and add additional, optional step in the default action.

Author: arik-so

.github/workflows/swift.yml

@@ -91,53 +91,16 @@ jobs:
                     RUST_BACKTRACE: 1
             -   name: Test Swift bindings package without address sanitizer
                 run: |
-                    python ci/toggle_address_sanitation_library.py off
                     cd ci/LDKSwift
                     ../../swift-5.6-RELEASE-ubuntu20.04/usr/bin/swift test -v
                 env:
                     LDK_C_BINDINGS_BASE: /home/runner/work/ldk-swift/ldk-swift/ci/ldk-c-bindings
-                    LLVM_CLANG_ASAN_PATH: /usr/lib/llvm-11/lib/clang/11.0.0/lib/linux/libclang_rt.asan-x86_64.a
                     RUST_BACKTRACE: 1
-            -   name: Archive code coverage results
-                uses: actions/upload-artifact@v3
-                with:
-                    name: ci_archive
-                    path: ci
-
-    test_bindings_with_sanitizer:
-        name: Test Bindings with Sanitizer
-        runs-on: ubuntu-20.04
-        needs: check_bindings
-        steps:
-            -   name: Download code coverage results archive
-                uses: actions/download-artifact@v3
-                with:
-                    name: ci_archive
-                    path: ci
-            -   name: Set up Python
-                uses: actions/setup-python@v2
-            -   name: Install Swift Toolchain
-                run: |
-                    curl --verbose -L -o swift-5.6-RELEASE-ubuntu20.04.tar.gz https://download.swift.org/swift-5.6-release/ubuntu2004/swift-5.6-RELEASE/swift-5.6-RELEASE-ubuntu20.04.tar.gz
-                    echo "Sha sum: $(sha256sum swift-5.6-RELEASE-ubuntu20.04.tar.gz | awk '{ print $1 }')"
-                    if [ "$(sha256sum swift-5.6-RELEASE-ubuntu20.04.tar.gz | awk '{ print $1 }')" != "${EXPECTED_SWIFT_SHASUM}" ]; then
-                      echo "Bad hash"
-                      echo "Contents: \n$(cat swift-5.6-RELEASE-ubuntu20.04.tar.gz)"
-                      exit 1
-                    fi
-                    tar xvvf swift-5.6-RELEASE-ubuntu20.04.tar.gz
-                env:
-                    EXPECTED_SWIFT_SHASUM: 3f0d926bfc08eea00a69b1d992f2ab5e08155d97476096a3ef959fe7c4cbd58b
-            -   name: Install Valgrind and build utilities
-                run: |
-                    sudo apt-get update
-                    sudo apt-get -y dist-upgrade
-                    sudo apt-get -y install valgrind lld g++ clang
             -   name: Test Swift bindings package with address sanitizer
+                continue-on-error: true
                 run: |
-                    python ci/toggle_address_sanitation_library.py on
                     cd ci/LDKSwift
-                    ../../swift-5.6-RELEASE-ubuntu20.04/usr/bin/swift test -Xswiftc -suppress-warnings
+                    ../../swift-5.6-RELEASE-ubuntu20.04/usr/bin/swift test -v
                 env:
                     LDK_C_BINDINGS_BASE: /home/runner/work/ldk-swift/ldk-swift/ci/ldk-c-bindings
                     LLVM_CLANG_ASAN_PATH: /usr/lib/llvm-11/lib/clang/11.0.0/lib/linux/libclang_rt.asan-x86_64.a

ci/LDKSwift/Package.swift

@@ -21,7 +21,9 @@ var linkerSettings: [PackageDescription.LinkerSetting] = [
 ]
 
 #if os(Linux)
-	linkerSettings.append(.linkedLibrary(String(utf8String: getenv("LLVM_CLANG_ASAN_PATH")!)!, .when(platforms: [.linux])))
+	if let addressSanitizerBinaryPath = getenv("LLVM_CLANG_ASAN_PATH") {
+		linkerSettings.append(.linkedLibrary(String(utf8String: addressSanitizerBinaryPath)!, .when(platforms: [.linux])))
+	}
 #else
 	linkerSettings = [
 		.unsafeFlags(["-L\(bindingsDirectory)"]),