Make traits' array paremeters internal for C structs

Author: arik-so

bindings/LDK/traits/Confirm.swift

@@ -165,7 +165,7 @@ public class NativelyImplementedConfirm: Confirm {
 	}
 
 @available(*, deprecated, message: "Use method taking Swift object array type instead.")
-	public override func transactions_confirmed(header: [UInt8]?, txdata: [LDKC2Tuple_usizeTransactionZ], height: UInt32) -> Void {
+	internal override func transactions_confirmed(header: [UInt8]?, txdata: [LDKC2Tuple_usizeTransactionZ], height: UInt32) -> Void {
 
 
 						let txdataWrapper = Bindings.new_LDKCVec_C2Tuple_usizeTransactionZZWrapper(array: txdata)

src/generators/opaque_struct_generator.py

@@ -55,7 +55,12 @@ def generate_opaque_struct(self, struct_name, struct_details, all_type_details={
 				cloneability_type_message = '; '.join(cloneability_types)
 				print(f'(opaque_struct_generator.py#constructor, warned, deprecated) {cloneability_warning}: {constructor_native_name} [{cloneability_type_message}]')
 
+			
 			mutating_output_file_contents = mutating_output_file_contents.replace('public init', f'{deprecation_prefix}public init')
+
+			if constructor_prepared_arguments['has_unwrapped_arrays']:
+				mutating_output_file_contents = mutating_output_file_contents.replace('public init(swift_constructor_arguments)', 'internal init(swift_constructor_arguments)')
+			
 			mutating_output_file_contents = mutating_output_file_contents.replace('swift_constructor_arguments', ', '.join(constructor_swift_arguments))
 			mutating_output_file_contents = mutating_output_file_contents.replace('OpaqueStructType(native_constructor_arguments)', constructor_native_call_prefix + 'OpaqueStructType(' + ', '.join(
 				constructor_native_arguments) + ')' + constructor_native_call_suffix)
@@ -64,8 +69,6 @@ def generate_opaque_struct(self, struct_name, struct_details, all_type_details={
 			mutating_output_file_contents = mutating_output_file_contents.replace('OpaqueStructType(', f'{constructor_native_name}(')
 
 			if constructor_prepared_arguments['has_unwrapped_arrays']:
-				# only replace the default init, don't replace the others
-				mutating_output_file_contents = mutating_output_file_contents.replace('public init', f'internal init', 1)
 
 				prepared_arguments = ConversionHelper.prepare_swift_to_native_arguments(constructor_details['argument_types'], array_unwrapping_preparation_only=True)
 				current_addition = method_template

src/generators/trait_generator.py

@@ -253,6 +253,9 @@ def generate_trait(self, struct_name, struct_details):
 			current_default_callback_replacement = natively_implemented_callback_template
 			current_default_callback_replacement = current_default_callback_replacement.replace('public_swift_argument_list', public_swift_argument_list)
 			current_default_callback_replacement = current_default_callback_replacement.replace('-> Void {', f'-> {swift_return_type} {{')
+			if default_callback_prepared_arguments['has_unwrapped_arrays']:
+				current_default_callback_replacement = current_default_callback_replacement.replace('public override func', 'internal override func')
+				
 			current_default_callback_replacement = current_default_callback_replacement.replace('func methodName(', f'func {current_lambda_name}(')
 			default_native_call_arguments = default_callback_prepared_arguments['native_arguments']