Skip to content

Commit bf04438

Browse files
committed
Update actions to work with xcodeproj
1 parent 7b37b90 commit bf04438

File tree

7 files changed

+23
-25
lines changed

7 files changed

+23
-25
lines changed

.github/actions/archive-framework/action.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@ inputs:
66
destination:
77
description: Destination
88
required: true
9-
workspace:
10-
description: Workspace Name
9+
project:
10+
description: Project directory, relative to the xcode folder
1111
required: true
1212
platform:
1313
description: Platform Name
@@ -22,7 +22,7 @@ runs:
2222
2323
xcodebuild archive \
2424
-scheme '${{ inputs.scheme }}' \
25-
-workspace '${{ inputs.workspace }}' \
25+
-project '${{ inputs.project }}' \
2626
-destination '${{ inputs.destination }}' \
2727
-archivePath "$BUILD_DIR/LDKFramework-${{ inputs.platform }}" \
2828
ENABLE_BITCODE=NO \

.github/actions/build-for-testing/action.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@ inputs:
66
destination:
77
description: Destination
88
required: true
9-
workspace:
10-
description: Workspace Name
9+
project:
10+
description: Project directory, relative to the xcode folder
1111
required: true
1212
description: Build for testing.
1313
runs:
@@ -21,7 +21,7 @@ runs:
2121
xcodebuild clean build-for-testing \
2222
-allowProvisioningUpdates \
2323
-allowProvisioningDeviceRegistration \
24-
-workspace '${{ inputs.workspace }}' \
24+
-project '${{ inputs.project }}' \
2525
-scheme '${{ inputs.scheme }}' \
2626
-destination '${{ inputs.destination }}' \
2727
-resultBundlePath BuildResults.xcresult \

.github/actions/test-without-building/action.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@ inputs:
1515
check-name:
1616
description: The check name
1717
required: true
18-
workspace:
19-
description: Workspace Name
18+
project:
19+
description: Project directory, relative to the xcode folder
2020
required: true
2121
runs:
2222
using: composite
@@ -30,7 +30,7 @@ runs:
3030
cd xcode
3131
3232
xcodebuild test-without-building \
33-
-workspace '${{ inputs.workspace }}' \
33+
-project '${{ inputs.project }}' \
3434
-scheme '${{ inputs.scheme }}' \
3535
-destination '${{ inputs.destination }}' \
3636
-resultBundlePath "${{ inputs.artifact-prefix }}-${{ steps.vars.outputs.sha_short }}.xcresult"

.github/workflows/build-frameworks.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,19 +24,19 @@ jobs:
2424
- scheme: LDKFramework
2525
destination: generic/platform=iOS
2626
platform: iOS
27-
workspace: LDKFramework.xcworkspace
27+
project: LDK/LightningDevKit.xcodeproj
2828
- scheme: LDKFramework
2929
destination: platform=iOS Simulator,OS=15.2,name=iPhone 13 Pro
3030
platform: iOS Simulator
31-
workspace: LDKFramework.xcworkspace
31+
project: LDK/LightningDevKit.xcodeproj
3232
- scheme: LDKFramework_Mac
3333
destination: generic/platform=OS X
3434
platform: OS X
35-
workspace: LDKFramework.xcworkspace
35+
project: LDK/LightningDevKit.xcodeproj
3636
- scheme: LDKFramework
3737
destination: platform=macOS,variant=Mac Catalyst,arch=x86_64
3838
platform: Mac Catalyst
39-
workspace: LDKFramework.xcworkspace
39+
project: LDK/LightningDevKit.xcodeproj
4040
env:
4141
DEVELOPER_DIR: /Applications/Xcode_13.2.1.app/Contents/Developer
4242
LDK_C_BINDINGS_BASE: /Users/runner/work/ldk-swift/ldk-swift/bindings/artifacts/ldk-c-bindings
@@ -54,6 +54,6 @@ jobs:
5454
id: build
5555
uses: ./.github/actions/build-for-testing
5656
with:
57-
workspace: ${{ matrix.configuration['workspace'] }}
57+
project: ${{ matrix.configuration['project'] }}
5858
scheme: ${{ matrix.configuration['scheme'] }}
5959
destination: ${{ matrix.configuration['destination'] }}

.github/workflows/direct-bindings-app-tests.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,11 +25,11 @@ jobs:
2525
- scheme: DirectBindingsApp
2626
destination: platform=iOS Simulator,OS=15.4,name=iPhone 13 Pro
2727
platform: iOS Simulator
28-
workspace: LDKFramework.xcworkspace
28+
project: DirectBindingsApp/DirectBindingsApp.xcodeproj
2929
- scheme: DirectBindingsAppTests
3030
destination: platform=iOS Simulator,OS=15.4,name=iPhone 13 Pro
3131
platform: iOS Simulator
32-
workspace: LDKFramework.xcworkspace
32+
project: DirectBindingsApp/DirectBindingsApp.xcodeproj
3333
xcode-unit-test: DirectBindingsAppTests
3434
env:
3535
DEVELOPER_DIR: /Applications/Xcode_13.3.1.app/Contents/Developer
@@ -46,15 +46,15 @@ jobs:
4646
id: build
4747
uses: ./.github/actions/build-for-testing
4848
with:
49-
workspace: ${{ matrix.configuration['workspace'] }}
49+
project: ${{ matrix.configuration['project'] }}
5050
scheme: ${{ matrix.configuration['scheme'] }}
5151
destination: ${{ matrix.configuration['destination'] }}
5252
- name: Xcode Unit Test
5353
if: ${{ matrix.configuration['xcode-unit-test'] != '' }}
5454
continue-on-error: true
5555
uses: ./.github/actions/test-without-building
5656
with:
57-
workspace: ${{ matrix.configuration['workspace'] }}
57+
project: ${{ matrix.configuration['project'] }}
5858
scheme: ${{ matrix.configuration['scheme'] }}
5959
destination: ${{ matrix.configuration['destination'] }}
6060
test-plan: ${{ matrix.configuration['xcode-unit-test'] }}

.github/workflows/release-framework.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,19 +21,19 @@ jobs:
2121
- scheme: LDKFramework
2222
destination: generic/platform=iOS
2323
platform: iOS
24-
workspace: LDKFramework.xcworkspace
24+
project: LDK/LightningDevKit.xcodeproj
2525
- scheme: LDKFramework
2626
destination: generic/platform=iOS Simulator
2727
platform: iOS Simulator
28-
workspace: LDKFramework.xcworkspace
28+
project: LDK/LightningDevKit.xcodeproj
2929
- scheme: LDKFramework_Mac
3030
destination: generic/platform=OS X
3131
platform: Darwin
32-
workspace: LDKFramework.xcworkspace
32+
project: LDK/LightningDevKit.xcodeproj
3333
- scheme: LDKFramework
3434
destination: generic/platform=macOS
3535
platform: Catalyst
36-
workspace: LDKFramework.xcworkspace
36+
project: LDK/LightningDevKit.xcodeproj
3737
env:
3838
DEVELOPER_DIR: /Applications/Xcode_13.2.1.app/Contents/Developer
3939
BUILD_DIR: ./build
@@ -51,7 +51,7 @@ jobs:
5151
- name: Archive
5252
uses: ./.github/actions/archive-framework
5353
with:
54-
workspace: ${{ matrix.configuration['workspace'] }}
54+
project: ${{ matrix.configuration['project'] }}
5555
scheme: ${{ matrix.configuration['scheme'] }}
5656
destination: ${{ matrix.configuration['destination'] }}
5757
platform: ${{ matrix.configuration['platform'] }}

.gitignore

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,8 @@ ci/LDKSwift/Sources/*
1414
!ci/LDKSwift/Sources/LDKSwift/bindings/Bindings.swift
1515

1616
/xcode/LDKFramework/Build/
17-
/xcode/LDKFramework/LDKFramework.xcodeproj/project.xcworkspace/
1817
/xcode/LDKFramework/LDKFramework.xcodeproj/xcuserdata/
1918
/xcode/DirectBindingsApp/Build/
20-
/xcode/DirectBindingsApp/DirectBindingsApp.xcodeproj/project.xcworkspace/
2119
/xcode/DirectBindingsApp/DirectBindingsApp.xcodeproj/xcuserdata/
2220

2321
## User settings

0 commit comments

Comments
 (0)