Make raw property getters not deallocate their underlying objects.

Author: arik-so

bindings/LDK/options/Event.swift

@@ -202,7 +202,7 @@ Event_write(objPointer)
 					}
 
 					public func getOutput_script() -> [UInt8] {
-						return Bindings.LDKCVec_u8Z_to_array(nativeType: self.cOpaqueStruct!.output_script)
+						return Bindings.LDKCVec_u8Z_to_array(nativeType: self.cOpaqueStruct!.output_script, deallocate: false)
 					}
 
 					public func getUser_channel_id() -> UInt64 {
@@ -308,7 +308,7 @@ Event_write(objPointer)
 
 
 					public func getOutputs() -> [LDKSpendableOutputDescriptor] {
-						return Bindings.LDKCVec_SpendableOutputDescriptorZ_to_array(nativeType: self.cOpaqueStruct!.outputs)
+						return Bindings.LDKCVec_SpendableOutputDescriptorZ_to_array(nativeType: self.cOpaqueStruct!.outputs, deallocate: false)
 					}
 
 

bindings/LDK/options/Fallback.swift

@@ -139,7 +139,7 @@ Fallback_eq(aPointer, bPointer)
 					}
 
 					public func getProgram() -> [UInt8] {
-						return Bindings.LDKCVec_u8Z_to_array(nativeType: self.cOpaqueStruct!.program)
+						return Bindings.LDKCVec_u8Z_to_array(nativeType: self.cOpaqueStruct!.program, deallocate: false)
 					}
 
 

bindings/LDK/options/PaymentSendFailure.swift

@@ -48,21 +48,21 @@ public class PaymentSendFailure: NativeTypeWrapper {
 						if self.cOpaqueStruct?.tag != LDKPaymentSendFailure_PathParameterError {
 							return nil
 						}
-						return Bindings.LDKCVec_CResult_NoneAPIErrorZZ_to_array(nativeType: self.cOpaqueStruct!.path_parameter_error)
+						return Bindings.LDKCVec_CResult_NoneAPIErrorZZ_to_array(nativeType: self.cOpaqueStruct!.path_parameter_error, deallocate: false)
 					}
 
 					public func getValueAsAllFailedRetrySafe() -> [LDKAPIError]? {
 						if self.cOpaqueStruct?.tag != LDKPaymentSendFailure_AllFailedRetrySafe {
 							return nil
 						}
-						return Bindings.LDKCVec_APIErrorZ_to_array(nativeType: self.cOpaqueStruct!.all_failed_retry_safe)
+						return Bindings.LDKCVec_APIErrorZ_to_array(nativeType: self.cOpaqueStruct!.all_failed_retry_safe, deallocate: false)
 					}
 
 					public func getValueAsPartialFailure() -> [LDKCResult_NoneAPIErrorZ]? {
 						if self.cOpaqueStruct?.tag != LDKPaymentSendFailure_PartialFailure {
 							return nil
 						}
-						return Bindings.LDKCVec_CResult_NoneAPIErrorZZ_to_array(nativeType: self.cOpaqueStruct!.partial_failure)
+						return Bindings.LDKCVec_CResult_NoneAPIErrorZZ_to_array(nativeType: self.cOpaqueStruct!.partial_failure, deallocate: false)
 					}
 
 

bindings/LDK/structs/TxOut.swift

@@ -66,7 +66,7 @@ TxOut_clone(origPointer)
 
     public func get_script_pubkey() -> [UInt8] {
 
-        return Bindings.LDKCVec_u8Z_to_array(nativeType: self.cOpaqueStruct!.script_pubkey);
+        return Bindings.LDKCVec_u8Z_to_array(nativeType: self.cOpaqueStruct!.script_pubkey, deallocate: false);
     }
 
     public func get_value() -> UInt64 {

src/conversion_helper.py

@@ -322,7 +322,7 @@ def prepare_native_to_swift_callback_arguments(cls, argument_types):
 		}
 
 	@classmethod
-	def prepare_return_value(cls, return_type, is_clone_method = False, is_trait_instantiator = False):
+	def prepare_return_value(cls, return_type, is_clone_method = False, is_trait_instantiator = False, is_raw_property_getter = False):
 		rust_return_type = return_type.rust_obj
 		return_prefix = ''
 		return_suffix = ''
@@ -334,6 +334,8 @@ def prepare_return_value(cls, return_type, is_clone_method = False, is_trait_ins
 		if rust_return_type is not None and rust_return_type.startswith('LDK') and return_type_string.startswith('['):
 			return_prefix = f'Bindings.{rust_return_type}_to_array(nativeType: '
 			return_suffix = ')'
+			if rust_return_type.startswith('LDKCVec_') and is_raw_property_getter:
+				return_suffix = ', deallocate: false)'
 		elif return_type.swift_raw_type.startswith('(UInt8'):
 			# TODO: get array length
 			array_length = return_type.arr_len

src/generators/opaque_struct_generator.py

@@ -166,7 +166,7 @@ def generate_opaque_struct(self, struct_name, struct_details, all_type_details={
 			for current_field in struct_details.fields:
 				current_field_name = current_field['name']
 				current_field_type = current_field['field_details']
-				value_return_wrappers = ConversionHelper.prepare_return_value(current_field_type)
+				value_return_wrappers = ConversionHelper.prepare_return_value(current_field_type, is_raw_property_getter=True)
 				current_swift_return_type = value_return_wrappers['swift_type']
 				current_method_name = f'get_{current_field_name}'
 

src/generators/option_generator.py

@@ -343,6 +343,8 @@ def prepare_return_body(self, type_details):
 		if current_return_type.rust_obj is not None and current_return_type.rust_obj.startswith('LDK') and current_return_type.swift_type.startswith('['):
 			return_type_wrapper_prefix = f'Bindings.{current_return_type.rust_obj}_to_array(nativeType: '
 			return_type_wrapper_suffix = ')'
+			if current_return_type.rust_obj.startswith('LDKCVec_'):
+				return_type_wrapper_suffix = ', deallocate: false)'
 			current_replacement = current_replacement.replace('return self.cOpaqueStruct!.varName', f'return {return_type_wrapper_prefix}self.cOpaqueStruct!.varName{return_type_wrapper_suffix}')
 		elif current_return_type.swift_raw_type.startswith('(UInt8'):
 			# TODO: get array length