Rename OrderPayment to PaymentInfo

.. not super descriptive, but more in line with `ChannelInfo`

Author: tnull

src/lsps1/event.rs

@@ -9,7 +9,7 @@
 
 //! Contains LSPS1 event types
 
-use super::msgs::{ChannelInfo, OptionsSupported, OrderId, OrderParams, OrderPayment};
+use super::msgs::{ChannelInfo, OptionsSupported, OrderId, OrderParams, PaymentInfo};
 
 use crate::lsps0::ser::RequestId;
 use crate::prelude::String;
@@ -60,7 +60,7 @@ pub enum LSPS1ClientEvent {
 		/// The order created by client and approved by LSP.
 		order: OrderParams,
 		/// The details regarding payment of the order
-		payment: OrderPayment,
+		payment: PaymentInfo,
 		/// The details regarding state of the channel ordered.
 		channel: Option<ChannelInfo>,
 	},

src/lsps1/msgs.rs

@@ -132,7 +132,7 @@ pub struct CreateOrderResponse {
 	/// The current state of the order.
 	pub order_state: OrderState,
 	/// Contains details about how to pay for the order.
-	pub payment: OrderPayment,
+	pub payment: PaymentInfo,
 	/// Contains information about the channel state.
 	pub channel: Option<ChannelInfo>,
 }
@@ -151,7 +151,7 @@ pub enum OrderState {
 
 /// Details regarding how to pay for an order.
 #[derive(Clone, Debug, PartialEq, Eq, Deserialize, Serialize)]
-pub struct OrderPayment {
+pub struct PaymentInfo {
 	/// Indicates the current state of the payment.
 	pub state: PaymentState,
 	/// The total fee the LSP will charge to open this channel in satoshi.
@@ -175,7 +175,7 @@ pub struct OrderPayment {
 	pub onchain_payment: Option<OnchainPayment>,
 }
 
-/// The state of an [`OrderPayment`].
+/// The state of an [`PaymentInfo`].
 #[derive(Clone, Debug, PartialEq, Eq, Deserialize, Serialize)]
 #[serde(rename_all = "SCREAMING_SNAKE_CASE")]
 pub enum PaymentState {
@@ -399,7 +399,7 @@ mod tests {
 				"confirmed": false
 			}
 		}"#;
-		let _payment: OrderPayment = serde_json::from_str(json_str).unwrap();
+		let _payment: PaymentInfo = serde_json::from_str(json_str).unwrap();
 
 		let json_str = r#"{
 			"funded_at": "2012-04-23T18:25:43.511Z",

src/lsps1/service.rs

@@ -12,8 +12,8 @@
 use super::event::LSPS1ServiceEvent;
 use super::msgs::{
 	ChannelInfo, CreateOrderRequest, CreateOrderResponse, GetInfoResponse, GetOrderRequest,
-	LSPS1Message, LSPS1Request, LSPS1Response, OptionsSupported, OrderId, OrderParams,
-	OrderPayment, OrderState, LSPS1_CREATE_ORDER_REQUEST_ORDER_MISMATCH_ERROR_CODE,
+	LSPS1Message, LSPS1Request, LSPS1Response, OptionsSupported, OrderId, OrderParams, OrderState,
+	PaymentInfo, LSPS1_CREATE_ORDER_REQUEST_ORDER_MISMATCH_ERROR_CODE,
 };
 use super::utils::is_valid;
 use crate::message_queue::MessageQueue;
@@ -75,7 +75,7 @@ struct OutboundLSPS1Config {
 	order: OrderParams,
 	created_at: chrono::DateTime<Utc>,
 	expires_at: chrono::DateTime<Utc>,
-	payment: OrderPayment,
+	payment: PaymentInfo,
 }
 
 struct OutboundCRChannel {
@@ -86,7 +86,7 @@ struct OutboundCRChannel {
 impl OutboundCRChannel {
 	fn new(
 		order: OrderParams, created_at: chrono::DateTime<Utc>, expires_at: chrono::DateTime<Utc>,
-		order_id: OrderId, payment: OrderPayment,
+		order_id: OrderId, payment: PaymentInfo,
 	) -> Self {
 		Self {
 			state: OutboundRequestState::OrderCreated { order_id },
@@ -238,7 +238,7 @@ where
 	///
 	/// [`LSPS1ServiceEvent::RequestForPaymentDetails`]: crate::lsps1::event::LSPS1ServiceEvent::RequestForPaymentDetails
 	pub fn send_payment_details(
-		&self, request_id: RequestId, counterparty_node_id: &PublicKey, payment: OrderPayment,
+		&self, request_id: RequestId, counterparty_node_id: &PublicKey, payment: PaymentInfo,
 		created_at: chrono::DateTime<Utc>, expires_at: chrono::DateTime<Utc>,
 	) -> Result<(), APIError> {
 		let (result, response) = {