Rename BuyResponse::intercept_scid to jit_channel_scid

Previously, during a cleanup, we accidentally also renamed the actual
`BuyResponse` field, not only our internal variables. Here, we fix this
regression to reestablish compliance with the spec.

Author: tnull

src/lsps2/client.rs

@@ -269,7 +269,7 @@ where
 						action: ErrorAction::IgnoreAndLog(Level::Info),
 					})?;
 
-				if let Ok(intercept_scid) = result.intercept_scid.to_scid() {
+				if let Ok(intercept_scid) = result.jit_channel_scid.to_scid() {
 					self.pending_events.enqueue(Event::LSPS2Client(
 						LSPS2ClientEvent::InvoiceParametersReady {
 							request_id,
@@ -283,7 +283,7 @@ where
 					return Err(LightningError {
 						err: format!(
 							"Received buy response with an invalid intercept scid {:?}",
-							result.intercept_scid
+							result.jit_channel_scid
 						),
 						action: ErrorAction::IgnoreAndLog(Level::Info),
 					});

src/lsps2/msgs.rs

@@ -150,7 +150,7 @@ impl InterceptScid {
 #[derive(Clone, Debug, PartialEq, Eq, Deserialize, Serialize)]
 pub struct BuyResponse {
 	/// The intercept short channel id used by LSP to identify need to open channel.
-	pub intercept_scid: InterceptScid,
+	pub jit_channel_scid: InterceptScid,
 	/// The locktime expiry delta the lsp requires.
 	pub lsp_cltv_expiry_delta: u32,
 	/// A flag that indicates who is trusting who.

src/lsps2/service.rs

@@ -639,7 +639,7 @@ where
 								.insert_outbound_channel(intercept_scid, outbound_jit_channel);
 
 							let response = LSPS2Response::Buy(BuyResponse {
-								intercept_scid: intercept_scid.into(),
+								jit_channel_scid: intercept_scid.into(),
 								lsp_cltv_expiry_delta: cltv_expiry_delta,
 								client_trusts_lsp,
 							});