Refactor: Switch Into<ScriptBuf> to From<ShutdownScript>

tnull · tnull · commit 0293a3c80d3c · 2025-06-18T17:04:21.000+02:00
.. as Rust advises to only ever implement `From`, and let the compiler
derive `Into` automatically.
diff --git a/lightning/src/ln/script.rs b/lightning/src/ln/script.rs
@@ -203,9 +203,9 @@ impl TryFrom<(ScriptBuf, &InitFeatures)> for ShutdownScript {
 	}
 }
 
-impl Into<ScriptBuf> for ShutdownScript {
-	fn into(self) -> ScriptBuf {
-		match self.0 {
+impl From<ShutdownScript> for ScriptBuf {
+	fn from(value: ShutdownScript) -> Self {
+		match value.0 {
 			ShutdownScriptImpl::Legacy(pubkey) => {
 				ScriptBuf::new_p2wpkh(&WPubkeyHash::hash(&pubkey.serialize()))
 			},

Original file line number	Diff line number	Diff line change
`@@ -203,9 +203,9 @@ impl TryFrom<(ScriptBuf, &InitFeatures)> for ShutdownScript {`
`203`	`203`	`}`
`204`	`204`	`}`
`205`	`205`
`206`		`-impl Into<ScriptBuf> for ShutdownScript {`
`207`		`- fn into(self) -> ScriptBuf {`
`208`		`- match self.0 {`
	`206`	`+impl From<ShutdownScript> for ScriptBuf {`
	`207`	`+ fn from(value: ShutdownScript) -> Self {`
	`208`	`+ match value.0 {`
`209`	`209`	`ShutdownScriptImpl::Legacy(pubkey) => {`
`210`	`210`	`ScriptBuf::new_p2wpkh(&WPubkeyHash::hash(&pubkey.serialize()))`
`211`	`211`	`},`