Skip to content

Commit 05db67b

Browse files
committed
Use a smaller bit for UnknownFeature
When testing Bolt12Invoice unknown require feature handling, a large feature bit can cause SendError::TooBigPacket when creating an onion message. Use a smaller feature bit for UnknownFeature, which also has the added benefit of reducing test output.
1 parent e4ca166 commit 05db67b

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

lightning-types/src/features.rs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -567,7 +567,7 @@ mod sealed {
567567

568568
#[cfg(any(test, feature = "_test_utils"))]
569569
define_feature!(
570-
123456789,
570+
12345,
571571
UnknownFeature,
572572
[
573573
NodeContext,
@@ -1117,7 +1117,7 @@ mod tests {
11171117
features.set_unknown_feature_required();
11181118
assert!(features.requires_unknown_bits());
11191119
assert!(features.supports_unknown_bits());
1120-
assert_eq!(features.required_unknown_bits_from(&ChannelFeatures::empty()), vec![123456788]);
1120+
assert_eq!(features.required_unknown_bits_from(&ChannelFeatures::empty()), vec![12344]);
11211121

11221122
let mut features = ChannelFeatures::empty();
11231123
features.set_unknown_feature_optional();
@@ -1127,17 +1127,17 @@ mod tests {
11271127

11281128
let mut features = ChannelFeatures::empty();
11291129
features.set_unknown_feature_required();
1130-
features.set_custom_bit(123456786).unwrap();
1130+
features.set_custom_bit(12346).unwrap();
11311131
assert!(features.requires_unknown_bits());
11321132
assert!(features.supports_unknown_bits());
11331133
assert_eq!(
11341134
features.required_unknown_bits_from(&ChannelFeatures::empty()),
1135-
vec![123456786, 123456788]
1135+
vec![12344, 12346]
11361136
);
11371137

11381138
let mut limiter = ChannelFeatures::empty();
11391139
limiter.set_unknown_feature_optional();
1140-
assert_eq!(features.required_unknown_bits_from(&limiter), vec![123456786]);
1140+
assert_eq!(features.required_unknown_bits_from(&limiter), vec![12346]);
11411141
}
11421142

11431143
#[test]

0 commit comments

Comments
 (0)