Avoid blanket impls in bindings builds

TheBlueMatt · TheBlueMatt · commit 18f80d3ff437 · 2023-09-25T17:17:47.000Z
The C bindings implements `Deref` for all traits, so having a
blanket `Deref` implementation ends up conflicting with this.
diff --git a/lightning/src/routing/scoring.rs b/lightning/src/routing/scoring.rs
@@ -133,6 +133,7 @@ pub trait Score : ScoreLookUp + ScoreUpdate $(+ $supertrait)* {}
 #[cfg(not(c_bindings))]
 impl<T: ScoreLookUp + ScoreUpdate $(+ $supertrait)*> Score for T {}
 
+#[cfg(not(c_bindings))]
 impl<S: ScoreLookUp, T: Deref<Target=S>> ScoreLookUp for T {
 	type ScoreParams = S::ScoreParams;
 	fn channel_penalty_msat(
@@ -142,6 +143,7 @@ impl<S: ScoreLookUp, T: Deref<Target=S>> ScoreLookUp for T {
 	}
 }
 
+#[cfg(not(c_bindings))]
 impl<S: ScoreUpdate, T: DerefMut<Target=S>> ScoreUpdate for T {
 	fn payment_path_failed(&mut self, path: &Path, short_channel_id: u64) {
 		self.deref_mut().payment_path_failed(path, short_channel_id)

Original file line number	Diff line number	Diff line change
`@@ -133,6 +133,7 @@ pub trait Score : ScoreLookUp + ScoreUpdate $(+ $supertrait)* {}`
`133`	`133`	`#[cfg(not(c_bindings))]`
`134`	`134`	`impl<T: ScoreLookUp + ScoreUpdate $(+ $supertrait)*> Score for T {}`
`135`	`135`
	`136`	`+#[cfg(not(c_bindings))]`
`136`	`137`	`impl<S: ScoreLookUp, T: Deref<Target=S>> ScoreLookUp for T {`
`137`	`138`	`type ScoreParams = S::ScoreParams;`
`138`	`139`	`fn channel_penalty_msat(`
`@@ -142,6 +143,7 @@ impl<S: ScoreLookUp, T: Deref<Target=S>> ScoreLookUp for T {`
`142`	`143`	`}`
`143`	`144`	`}`
`144`	`145`
	`146`	`+#[cfg(not(c_bindings))]`
`145`	`147`	`impl<S: ScoreUpdate, T: DerefMut<Target=S>> ScoreUpdate for T {`
`146`	`148`	`fn payment_path_failed(&mut self, path: &Path, short_channel_id: u64) {`
`147`	`149`	`self.deref_mut().payment_path_failed(path, short_channel_id)`