f lol duh

Author: TheBlueMatt

lightning/src/util/wakers.rs

@@ -93,14 +93,16 @@ impl Notifier {
 			future_probably_generated_calls |= future_state.lock().unwrap().complete();
 			future_probably_generated_calls |= Arc::strong_count(&future_state) > 1;
 		}
-		if !future_probably_generated_calls {
-			// If no future made any callbacks and has been drop'd (i.e. the state has only the one
-			// reference we hold), assume the user was not notified and set the
-			// notification-required flag. This will cause the `wait` functions above to return.
-			lock.0 = true;
+		if future_probably_generated_calls {
+			// If a future made some callbacks or has not yet been drop'd (i.e. the state has more
+			// than the one reference we hold), assume the user was notified and skip setting the
+			// notification-required flag. This will not cause the `wait` functions above to return
+			// and avoid any future `Future`s starting in a completed state.
+			return;
 		}
+		lock.0 = true;
 		mem::drop(lock);
-		if !future_probably_generated_calls { self.condvar.notify_all(); }
+		self.condvar.notify_all();
 	}
 
 	/// Gets a [`Future`] that will get woken up with any waiters