Remove Result from into_channel methods

These methods always return Ok, so there is no need to use a Result.

Author: jkczyz

lightning/src/ln/channel.rs

@@ -8882,14 +8882,12 @@ impl<SP: Deref> OutboundV2Channel<SP> where SP::Target: SignerProvider {
 		}
 	}
 
-	pub fn into_channel(self) -> Result<Channel<SP>, ChannelError>{
+	pub fn into_channel(self) -> Channel<SP> {
 		debug_assert!(self.signing_session.is_some());
-		let channel = Channel {
+		Channel {
 			context: self.context,
 			interactive_tx_signing_session: self.signing_session,
-		};
-
-		Ok(channel)
+		}
 	}
 }
 
@@ -9079,14 +9077,12 @@ impl<SP: Deref> InboundV2Channel<SP> where SP::Target: SignerProvider {
 		self.generate_accept_channel_v2_message()
 	}
 
-	pub fn into_channel(self) -> Result<Channel<SP>, ChannelError>{
+	pub fn into_channel(self) -> Channel<SP> {
 		debug_assert!(self.signing_session.is_some());
-		let channel = Channel {
+		Channel {
 			context: self.context,
 			interactive_tx_signing_session: self.signing_session,
-		};
-
-		Ok(channel)
+		}
 	}
 }
 

lightning/src/ln/channelmanager.rs

@@ -8332,8 +8332,8 @@ where
 
 					let (channel_id, channel_phase) = chan_phase_entry.remove_entry();
 					let channel = match channel_phase {
-						ChannelPhase::UnfundedOutboundV2(chan) => chan.into_channel(),
-						ChannelPhase::UnfundedInboundV2(chan) => chan.into_channel(),
+						ChannelPhase::UnfundedOutboundV2(chan) => Ok(chan.into_channel()),
+						ChannelPhase::UnfundedInboundV2(chan) => Ok(chan.into_channel()),
 						_ => {
 							debug_assert!(false); // It cannot be another variant as we are in the `Ok` branch of the above match.
 							Err(ChannelError::Warn(