fixup: on background-processor, use LightningLiquidity::new instead of the custom time provider constructor

Author: martinsaposnic

lightning-background-processor/Cargo.toml

@@ -14,9 +14,10 @@ all-features = true
 rustdoc-args = ["--cfg", "docsrs"]
 
 [features]
+default = ["std", "time"]
 std = ["lightning/std", "lightning-liquidity/std", "bitcoin-io/std", "bitcoin_hashes/std"]
+time = ["std", "lightning-liquidity/time"]
 
-default = ["std"]
 
 [dependencies]
 bitcoin = { version = "0.32.2", default-features = false }

lightning-background-processor/src/lib.rs

@@ -648,7 +648,7 @@ use futures_util::{dummy_waker, OptionalSelector, Selector, SelectorOutput};
 /// # use std::sync::atomic::{AtomicBool, Ordering};
 /// # use std::time::SystemTime;
 /// # use lightning_background_processor::{process_events_async, GossipSync};
-/// # use lightning_liquidity::lsps5::service::TimeProvider;
+/// # use lightning_liquidity::lsps5::service::DefaultTimeProvider;
 /// # struct Logger {}
 /// # impl lightning::util::logger::Logger for Logger {
 /// #     fn log(&self, _record: lightning::util::logger::Record) {}
@@ -661,15 +661,6 @@ use futures_util::{dummy_waker, OptionalSelector, Selector, SelectorOutput};
 /// #     fn list(&self, primary_namespace: &str, secondary_namespace: &str) -> io::Result<Vec<String>> { Ok(Vec::new()) }
 /// # }
 /// #
-/// # use core::time::Duration;
-/// # struct DefaultTimeProvider;
-/// #
-/// # impl TimeProvider for DefaultTimeProvider {
-/// #    fn duration_since_epoch(&self) -> Duration {
-/// #        use std::time::{SystemTime, UNIX_EPOCH};
-/// #        SystemTime::now().duration_since(UNIX_EPOCH).expect("system time before Unix epoch")
-/// #    }
-/// # }
 /// # struct EventHandler {}
 /// # impl EventHandler {
 /// #     async fn handle_event(&self, _: lightning::events::Event) -> Result<(), ReplayEvent> { Ok(()) }
@@ -1162,7 +1153,7 @@ impl Drop for BackgroundProcessor {
 	}
 }
 
-#[cfg(all(feature = "std", test))]
+#[cfg(all(feature = "std", feature = "time", test))]
 mod tests {
 	use super::{BackgroundProcessor, GossipSync, FRESHNESS_TIMER};
 	use bitcoin::constants::{genesis_block, ChainHash};
@@ -1207,7 +1198,7 @@ mod tests {
 	use lightning::util::sweep::{OutputSpendStatus, OutputSweeperSync, PRUNE_DELAY_BLOCKS};
 	use lightning::util::test_utils;
 	use lightning::{get_event, get_event_msg};
-	use lightning_liquidity::lsps5::service::TimeProvider;
+	use lightning_liquidity::lsps5::service::DefaultTimeProvider;
 	use lightning_liquidity::LiquidityManager;
 	use lightning_persister::fs_store::FilesystemStore;
 	use lightning_rapid_gossip_sync::RapidGossipSync;
@@ -1650,16 +1641,6 @@ mod tests {
 		path.to_str().unwrap().to_string()
 	}
 
-	pub struct DefaultTimeProvider;
-
-	#[cfg(feature = "std")]
-	impl TimeProvider for DefaultTimeProvider {
-		fn duration_since_epoch(&self) -> Duration {
-			use std::time::{SystemTime, UNIX_EPOCH};
-			SystemTime::now().duration_since(UNIX_EPOCH).expect("system time before Unix epoch")
-		}
-	}
-
 	fn create_nodes(num_nodes: usize, persist_dir: &str) -> (String, Vec<Node>) {
 		let persist_temp_path = env::temp_dir().join(persist_dir);
 		let persist_dir = persist_temp_path.to_string_lossy().to_string();
@@ -1761,15 +1742,13 @@ mod tests {
 				Arc::clone(&logger),
 				Arc::clone(&keys_manager),
 			));
-			let time_provider = Arc::new(DefaultTimeProvider);
-			let liquidity_manager = Arc::new(LiquidityManager::new_with_custom_time_provider(
+			let liquidity_manager = Arc::new(LiquidityManager::new(
 				Arc::clone(&keys_manager),
 				Arc::clone(&manager),
 				None,
 				None,
 				None,
 				None,
-				time_provider,
 			));
 			let node = Node {
 				node: manager,