Delete HTLCDescriptor::tx_input_witness

Author: tankyleo

lightning/src/events/bump_transaction.rs

@@ -182,10 +182,8 @@ pub enum BumpTransactionEvent {
 	///
 	/// The consumer should be able to sign for any of the non-HTLC inputs added to the resulting
 	/// HTLC transaction. To sign HTLC inputs, an [`EcdsaChannelSigner`] should be re-derived
-	/// through [`HTLCDescriptor::derive_channel_signer`]. Each HTLC input's signature can be
-	/// computed with [`ChannelSigner::sign_holder_htlc_transaction`], which can then be
-	/// provided to [`HTLCDescriptor::tx_input_witness`] to obtain the fully signed witness required
-	/// to spend.
+	/// through [`HTLCDescriptor::derive_channel_signer`]. Each HTLC input's witness can be
+	/// computed with [`ChannelSigner::sign_holder_htlc_transaction`].
 	///
 	/// It is possible to receive more than one instance of this event if a valid HTLC transaction
 	/// is never broadcast or is but not with a sufficient fee to be mined. Care should be taken by

lightning/src/sign/mod.rs

@@ -18,7 +18,7 @@ use bitcoin::ecdsa::Signature as EcdsaSignature;
 use bitcoin::locktime::absolute::LockTime;
 use bitcoin::network::Network;
 use bitcoin::opcodes;
-use bitcoin::script::{Builder, Script, ScriptBuf};
+use bitcoin::script::{Builder, ScriptBuf};
 use bitcoin::sighash;
 use bitcoin::sighash::EcdsaSighashType;
 use bitcoin::transaction::Version;
@@ -626,18 +626,6 @@ impl HTLCDescriptor {
 		)
 	}
 
-	/// Returns the fully signed witness required to spend the HTLC output in the commitment
-	/// transaction.
-	pub fn tx_input_witness(&self, signature: &Signature, witness_script: &Script) -> Witness {
-		chan_utils::build_htlc_input_witness(
-			signature,
-			&self.counterparty_sig,
-			&self.preimage,
-			witness_script,
-			self.channel_derivation_parameters.transaction_parameters.channel_type_features(),
-		)
-	}
-
 	/// Derives the channel signer required to sign the HTLC input.
 	pub fn derive_channel_signer<S: EcdsaChannelSigner, SP: Deref>(&self, signer_provider: &SP) -> S
 	where