Sort out PendingSplicePre and -Post, new_spliced for ChannelContext and OutboundV2Channel

Author: optout21

lightning/src/ln/channel.rs

@@ -4909,7 +4909,6 @@ impl<SP: Deref> ChannelContext<SP> where SP::Target: SignerProvider {
 			latest_monitor_update_id: self.latest_monitor_update_id,
 			shutdown_scriptpubkey: self.shutdown_scriptpubkey.clone(),
 			destination_script: self.destination_script.clone(),
-			// holder_commitment_point: self.holder_commitment_point,
 			cur_counterparty_commitment_transaction_number: self.cur_counterparty_commitment_transaction_number,
 			// value_to_self_msat: self.value_to_self_msat,
 			pending_inbound_htlcs: self.pending_inbound_htlcs.clone(),
@@ -10364,6 +10363,7 @@ impl<SP: Deref> PendingV2Channel<SP> where SP::Target: SignerProvider {
 			},
 			interactive_tx_constructor: None,
 			interactive_tx_signing_session: None,
+			#[cfg(splicing)]
 			pending_splice_post: None,
 		};
 		Ok(chan)
@@ -10373,7 +10373,7 @@ impl<SP: Deref> PendingV2Channel<SP> where SP::Target: SignerProvider {
 	#[cfg(splicing)]
 	pub fn new_spliced<L: Deref>(
 		is_outbound: bool,
-		pre_splice_channel: &mut FundedChannel<SP>,
+		pre_splice_channel: &FundedChannel<SP>,
 		signer_provider: &SP,
 		// counterparty_funding_pubkey: &PublicKey,
 		our_funding_contribution: i64,
@@ -10407,7 +10407,7 @@ impl<SP: Deref> PendingV2Channel<SP> where SP::Target: SignerProvider {
 		let (context, funding) = ChannelContext::new_for_splice(
 			&pre_splice_channel.context,
 			&pre_splice_channel.funding,
-			true,
+			is_outbound,
 			// counterparty_funding_pubkey,
 			our_funding_contribution,
 			their_funding_contribution,

lightning/src/ln/functional_tests_splice.rs

@@ -221,6 +221,10 @@ fn test_v1_splice_in() {
 
 	// ==== Channel is now ready for normal operation
 
+	// Expected balances
+	let mut exp_balance1 = 1000 * channel_value_sat;
+	let mut exp_balance2 = 0;
+	
 	// === Start of Splicing
 	println!("Start of Splicing ..., channel_id {}", channel_id2);
 
@@ -276,8 +280,8 @@ fn test_v1_splice_in() {
 		assert!(channel.is_usable);
 		assert!(channel.is_channel_ready);
 		assert_eq!(channel.channel_value_satoshis, channel_value_sat);
-		assert_eq!(channel.outbound_capacity_msat, 0);
-		assert!(channel.funding_txo.is_some());
+		assert_eq!(channel.outbound_capacity_msat, exp_balance2);
+		assert_eq!(channel.funding_txo.unwrap().txid, funding_tx.compute_txid());
 		assert!(channel.confirmations.unwrap() > 0);
 	}
 
@@ -295,9 +299,9 @@ fn test_v1_splice_in() {
 		assert_eq!(channel.channel_value_satoshis, channel_value_sat);
 		assert_eq!(
 			channel.outbound_capacity_msat,
-			1000 * (channel_value_sat - channel_reserve_amnt_sat)
+			exp_balance1 - 1000 * channel_reserve_amnt_sat
 		);
-		assert!(channel.funding_txo.is_some());
+		assert_eq!(channel.funding_txo.unwrap().txid, funding_tx.compute_txid());
 		assert!(channel.confirmations.unwrap() > 0);
 	}