s - drop redundant LocalHTLCFailureReason::AmountExceedsCapacity

Author: jkczyz

lightning/src/ln/channel.rs

@@ -9146,14 +9146,6 @@ impl<SP: Deref> FundedChannel<SP> where
 				"Cannot send HTLC until channel is fully established and we haven't started shutting down".to_owned()));
 		}
 
-		for funding in core::iter::once(&self.funding).chain(self.pending_funding.iter()) {
-			let channel_total_msat = funding.get_value_satoshis() * 1000;
-			if amount_msat > channel_total_msat {
-				return Err((LocalHTLCFailureReason::AmountExceedsCapacity,
-					format!("Cannot send amount {}, because it is more than the total value of the channel {}", amount_msat, channel_total_msat)));
-			}
-		}
-
 		if amount_msat == 0 {
 			return Err((LocalHTLCFailureReason::ZeroAmount, "Cannot send 0-msat HTLC".to_owned()));
 		}

lightning/src/ln/onion_utils.rs

@@ -1590,8 +1590,6 @@ pub enum LocalHTLCFailureReason {
 	/// The HTLC was failed back because its expiry height was reached and funds were timed out
 	/// on chain.
 	OnChainTimeout,
-	/// The HTLC was failed because its amount is greater than the capacity of the channel.
-	AmountExceedsCapacity,
 	/// The HTLC was failed because zero amount HTLCs are not allowed.
 	ZeroAmount,
 	/// The HTLC was failed because its amount is less than the smallest HTLC that the channel
@@ -1625,7 +1623,6 @@ impl LocalHTLCFailureReason {
 			| Self::DustLimitCounterparty
 			| Self::FeeSpikeBuffer
 			| Self::ChannelNotReady
-			| Self::AmountExceedsCapacity
 			| Self::ZeroAmount
 			| Self::HTLCMinimum
 			| Self::HTLCMaximum
@@ -1780,11 +1777,10 @@ impl_writeable_tlv_based_enum!(LocalHTLCFailureReason,
 	(71, OutgoingCLTVTooSoon) => {},
 	(73, ChannelClosed) => {},
 	(75, OnChainTimeout) => {},
-	(77, AmountExceedsCapacity) => {},
-	(79, ZeroAmount) => {},
-	(81, HTLCMinimum) => {},
-	(83, HTLCMaximum) => {},
-	(85, PeerOffline) => {},
+	(77, ZeroAmount) => {},
+	(79, HTLCMinimum) => {},
+	(81, HTLCMaximum) => {},
+	(83, PeerOffline) => {},
 );
 
 impl From<&HTLCFailReason> for HTLCHandlingFailureReason {
@@ -1897,7 +1893,6 @@ impl HTLCFailReason {
 			| LocalHTLCFailureReason::DustLimitCounterparty
 			| LocalHTLCFailureReason::FeeSpikeBuffer
 			| LocalHTLCFailureReason::ChannelNotReady
-			| LocalHTLCFailureReason::AmountExceedsCapacity
 			| LocalHTLCFailureReason::ZeroAmount
 			| LocalHTLCFailureReason::HTLCMinimum
 			| LocalHTLCFailureReason::HTLCMaximum