update existing tests to use contructors

Author: Prabhat1308

lightning/src/util/persist.rs

@@ -1419,26 +1419,36 @@ mod tests {
 	fn clean_stale_updates_works() {
 		let test_max_pending_updates = 7;
 		let chanmon_cfgs = create_chanmon_cfgs(3);
-		let persister_0 = MonitorUpdatingPersister {
-			kv_store: &TestStore::new(false),
-			logger: &TestLogger::new(),
-			maximum_pending_updates: test_max_pending_updates,
-			min_monitor_size_for_updates_bytes: 0,
-			entropy_source: &chanmon_cfgs[0].keys_manager,
-			signer_provider: &chanmon_cfgs[0].keys_manager,
-			broadcaster: &chanmon_cfgs[0].tx_broadcaster,
-			fee_estimator: &chanmon_cfgs[0].fee_estimator,
-		};
-		let persister_1 = MonitorUpdatingPersister {
-			kv_store: &TestStore::new(false),
-			logger: &TestLogger::new(),
-			maximum_pending_updates: test_max_pending_updates,
-			min_monitor_size_for_updates_bytes: 0,
-			entropy_source: &chanmon_cfgs[1].keys_manager,
-			signer_provider: &chanmon_cfgs[1].keys_manager,
-			broadcaster: &chanmon_cfgs[1].tx_broadcaster,
-			fee_estimator: &chanmon_cfgs[1].fee_estimator,
-		};
+		let store_0 = TestStore::new(false);
+		let logger_0 = TestLogger::new();
+		let store_1 = TestStore::new(false);
+		let logger_1 = TestLogger::new();
+
+		// Test the default new() constructor (uses 4096 byte threshold)
+		let persister_0 = MonitorUpdatingPersister::new(
+			&store_0,
+			&logger_0,
+			test_max_pending_updates,
+			&chanmon_cfgs[0].keys_manager,
+			&chanmon_cfgs[0].keys_manager,
+			&chanmon_cfgs[0].tx_broadcaster,
+			&chanmon_cfgs[0].fee_estimator,
+		);
+		// Test the custom threshold constructor with zero threshold
+		let persister_1 = MonitorUpdatingPersister::new_with_monitor_size_threshold(
+			&store_1,
+			&logger_1,
+			test_max_pending_updates,
+			0, // 0 byte threshold for maximum update usage
+			&chanmon_cfgs[1].keys_manager,
+			&chanmon_cfgs[1].keys_manager,
+			&chanmon_cfgs[1].tx_broadcaster,
+			&chanmon_cfgs[1].fee_estimator,
+		);
+
+		// Verify the constructors set the thresholds correctly
+		assert_eq!(persister_0.min_monitor_size_for_updates_bytes, 4096);
+		assert_eq!(persister_1.min_monitor_size_for_updates_bytes, 0);
 		let mut node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
 		let chain_mon_0 = test_utils::TestChainMonitor::new(
 			Some(&chanmon_cfgs[0].chain_source),
@@ -1505,32 +1515,42 @@ mod tests {
 	#[test]
 	fn test_size_based_optimization() {
 		let chanmon_cfgs = create_chanmon_cfgs(2);
+		let store_0 = TestStore::new(false);
+		let logger_0 = TestLogger::new();
+		let store_1 = TestStore::new(false);
+		let logger_1 = TestLogger::new();
 
 		// Create a persister with a huge minimum size threshold (100KB)
 		// This should force all monitors to use full persistence instead of updates
-		let large_threshold_persister = MonitorUpdatingPersister {
-			kv_store: &TestStore::new(false),
-			logger: &TestLogger::new(),
-			maximum_pending_updates: 5,
-			min_monitor_size_for_updates_bytes: 100_000, // 100KB threshold - way larger than any monitor
-			entropy_source: &chanmon_cfgs[0].keys_manager,
-			signer_provider: &chanmon_cfgs[0].keys_manager,
-			broadcaster: &chanmon_cfgs[0].tx_broadcaster,
-			fee_estimator: &chanmon_cfgs[0].fee_estimator,
-		};
+		// Test the new_with_monitor_size_threshold constructor with large threshold
+		let large_threshold_persister = MonitorUpdatingPersister::new_with_monitor_size_threshold(
+			&store_0,
+			&logger_0,
+			5,
+			100_000, // 100KB threshold - way larger than any monitor
+			&chanmon_cfgs[0].keys_manager,
+			&chanmon_cfgs[0].keys_manager,
+			&chanmon_cfgs[0].tx_broadcaster,
+			&chanmon_cfgs[0].fee_estimator,
+		);
 
 		// Create a persister with zero minimum size threshold
 		// This should allow all monitors to use update-based persistence
-		let small_threshold_persister = MonitorUpdatingPersister {
-			kv_store: &TestStore::new(false),
-			logger: &TestLogger::new(),
-			maximum_pending_updates: 5,
-			min_monitor_size_for_updates_bytes: 0, // 0 byte threshold - allows all monitors to use updates
-			entropy_source: &chanmon_cfgs[1].keys_manager,
-			signer_provider: &chanmon_cfgs[1].keys_manager,
-			broadcaster: &chanmon_cfgs[1].tx_broadcaster,
-			fee_estimator: &chanmon_cfgs[1].fee_estimator,
-		};
+		// Test the new_with_monitor_size_threshold constructor with zero threshold
+		let small_threshold_persister = MonitorUpdatingPersister::new_with_monitor_size_threshold(
+			&store_1,
+			&logger_1,
+			5,
+			0, // 0 byte threshold - allows all monitors to use updates
+			&chanmon_cfgs[1].keys_manager,
+			&chanmon_cfgs[1].keys_manager,
+			&chanmon_cfgs[1].tx_broadcaster,
+			&chanmon_cfgs[1].fee_estimator,
+		);
+
+		// Verify the constructors set the thresholds correctly
+		assert_eq!(large_threshold_persister.min_monitor_size_for_updates_bytes, 100_000);
+		assert_eq!(small_threshold_persister.min_monitor_size_for_updates_bytes, 0);
 
 		let mut node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
 		let chain_mon_0 = test_utils::TestChainMonitor::new(