f - pass sender by value for consistency

jkczyz · jkczyz · commit 4b4012210048 · 2023-06-02T12:02:32.000-05:00
diff --git a/fuzz/src/onion_message.rs b/fuzz/src/onion_message.rs
@@ -59,7 +59,7 @@ struct TestMessageRouter {}
 
 impl MessageRouter for TestMessageRouter {
 	fn find_path(
-		&self, _sender: &PublicKey, _peers: Vec<PublicKey>, _destination: Destination
+		&self, _sender: PublicKey, _peers: Vec<PublicKey>, _destination: Destination
 	) -> Result<OnionMessagePath, ()> {
 		unreachable!()
 	}
diff --git a/lightning/src/onion_message/functional_tests.rs b/lightning/src/onion_message/functional_tests.rs
@@ -49,7 +49,7 @@ struct TestMessageRouter {}
 
 impl MessageRouter for TestMessageRouter {
 	fn find_path(
-		&self, _sender: &PublicKey, _peers: Vec<PublicKey>, _destination: Destination
+		&self, _sender: PublicKey, _peers: Vec<PublicKey>, _destination: Destination
 	) -> Result<OnionMessagePath, ()> {
 		todo!()
 	}
diff --git a/lightning/src/onion_message/messenger.rs b/lightning/src/onion_message/messenger.rs
@@ -58,7 +58,7 @@ use crate::prelude::*;
 /// # }
 /// # struct FakeMessageRouter {}
 /// # impl MessageRouter for FakeMessageRouter {
-/// #     fn find_path(&self, sender: &PublicKey, peers: Vec<PublicKey>, destination: Destination) -> Result<OnionMessagePath, ()> {
+/// #     fn find_path(&self, sender: PublicKey, peers: Vec<PublicKey>, destination: Destination) -> Result<OnionMessagePath, ()> {
 /// #         unimplemented!()
 /// #     }
 /// # }
@@ -149,7 +149,7 @@ pub trait MessageRouter {
 	///
 	/// [`OnionMessage`]: msgs::OnionMessage
 	fn find_path(
-		&self, sender: &PublicKey, peers: Vec<PublicKey>, destination: Destination
+		&self, sender: PublicKey, peers: Vec<PublicKey>, destination: Destination
 	) -> Result<OnionMessagePath, ()>;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ struct TestMessageRouter {}`
`59`	`59`
`60`	`60`	`impl MessageRouter for TestMessageRouter {`
`61`	`61`	`fn find_path(`
`62`		`- &self, _sender: &PublicKey, _peers: Vec<PublicKey>, _destination: Destination`
	`62`	`+ &self, _sender: PublicKey, _peers: Vec<PublicKey>, _destination: Destination`
`63`	`63`	`) -> Result<OnionMessagePath, ()> {`
`64`	`64`	`unreachable!()`
`65`	`65`	`}`
Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,7 @@ struct TestMessageRouter {}`
`49`	`49`
`50`	`50`	`impl MessageRouter for TestMessageRouter {`
`51`	`51`	`fn find_path(`
`52`		`- &self, _sender: &PublicKey, _peers: Vec<PublicKey>, _destination: Destination`
	`52`	`+ &self, _sender: PublicKey, _peers: Vec<PublicKey>, _destination: Destination`
`53`	`53`	`) -> Result<OnionMessagePath, ()> {`
`54`	`54`	`todo!()`
`55`	`55`	`}`