create new fuzz script and add to coverage job

Author: Prabhat1308

.github/workflows/build.yml

@@ -126,6 +126,7 @@ jobs:
           # Could you use this to fake the coverage report for your PR? Sure.
           # Will anyone be impressed by your amazing coverage? No
           # Maybe if codecov wasn't broken we wouldn't need to do this...
+          ./ci/ci-fuzz.sh
           bash <(curl -s https://codecov.io/bash) -f target/codecov.json -t "f421b687-4dc2-4387-ac3d-dc3b2528af57"
 
   benchmark:

ci/ci-fuzz.sh

@@ -0,0 +1,18 @@
+#!/bin/bash
+set -eox pipefail
+
+echo -e "\n\nGenerating fuzz coverage report"
+# In CI, store coverage in a specific directory for artifact collection
+COVERAGE_DIR="coverage-report"
+echo "Installing cargo-llvm-cov..."
+# Install cargo-llvm-cov if not already installed
+cargo install cargo-llvm-cov --locked
+echo "Running fuzz coverage generation..."
+./contrib/generate_fuzz_coverage.sh --output-dir "$COVERAGE_DIR"
+echo "Coverage generation completed. Checking results..."
+if [ -f "fuzz/$COVERAGE_DIR/html/index.html" ]; then
+    echo "✓ Coverage report successfully generated at fuzz/$COVERAGE_DIR/html/index.html"
+    ls -la "fuzz/$COVERAGE_DIR/html/"
+else
+    echo "✗ Coverage report not found at expected location"
+fi

ci/ci-tests.sh

@@ -137,28 +137,3 @@ RUSTFLAGS="--cfg=splicing" cargo test --verbose --color always -p lightning
 RUSTFLAGS="--cfg=async_payments" cargo test --verbose --color always -p lightning
 [ "$CI_MINIMIZE_DISK_USAGE" != "" ] && cargo clean
 RUSTFLAGS="--cfg=lsps1_service" cargo test --verbose --color always -p lightning-liquidity
-
-# Generate fuzz coverage report
-echo -e "\n\nGenerating fuzz coverage report"
-if [ -n "$CI" ]; then
-    # In CI, store coverage in a specific directory for artifact collection
-    COVERAGE_DIR="coverage-report"
-    mkdir -p "$COVERAGE_DIR"
-    echo "Installing cargo-llvm-cov..."
-    # Install cargo-llvm-cov if not already installed
-    cargo install cargo-llvm-cov --locked
-    echo "Running fuzz coverage generation..."
-    ./contrib/generate_fuzz_coverage.sh --output-dir "$COVERAGE_DIR"
-    echo "Coverage generation completed. Checking results..."
-    if [ -f "fuzz/$COVERAGE_DIR/html/index.html" ]; then
-        echo "✓ Coverage report successfully generated at fuzz/$COVERAGE_DIR/html/index.html"
-        ls -la "fuzz/$COVERAGE_DIR/html/"
-    else
-        echo "✗ Coverage report not found at expected location"
-        echo "Checking what was created in fuzz/$COVERAGE_DIR:"
-        ls -la "fuzz/$COVERAGE_DIR" || echo "Directory does not exist"
-    fi
-else
-    # Local development
-    ./contrib/generate_fuzz_coverage.sh
-fi

contrib/generate_fuzz_coverage.sh

@@ -3,7 +3,7 @@ set -e
 set -x
 
 # Parse command line arguments
-OUTPUT_DIR="target/llvm-cov/html"
+OUTPUT_DIR="coverage-report"
 while [[ $# -gt 0 ]]; do
     case $1 in
         --output-dir)
@@ -56,7 +56,7 @@ export RUSTFLAGS="--cfg=fuzzing --cfg=secp256k1_fuzz --cfg=hashes_fuzz"
 cargo llvm-cov --html --ignore-filename-regex "fuzz/" --output-dir "$OUTPUT_DIR"
 
 # Check if coverage report was generated successfully
-# The report is generated directly in $OUTPUT_DIR/html/index.html
+# The report is generated in $OUTPUT_DIR/html/index.html when using --html --output-dir
 if [ ! -f "$OUTPUT_DIR/html/index.html" ]; then
     echo "Error: Failed to generate coverage report at $OUTPUT_DIR/html/index.html"
     # Debug: list what was actually created