Improve error handling, persistence; misc review changes

optout21 · optout21 · commit 4ed2f85c4674 · 2025-03-08T08:33:57.000+01:00
diff --git a/lightning/src/ln/channel.rs b/lightning/src/ln/channel.rs
@@ -13107,15 +13107,15 @@ mod tests {
 		}
 	}
 
-	#[cfg(all(test, splicing))]
+	#[cfg(splicing)]
 	fn get_pre_and_post(pre_channel_value: u64, our_funding_contribution: i64, their_funding_contribution: i64) -> (u64, u64) {
 		use crate::ln::channel::PendingSplice;
 
 		let post_channel_value = PendingSplice::compute_post_value(pre_channel_value, our_funding_contribution, their_funding_contribution);
 		(pre_channel_value, post_channel_value)
 	}
 
-	#[cfg(all(test, splicing))]
+	#[cfg(splicing)]
 	#[test]
 	fn test_splice_compute_post_value() {
 		{

Original file line number	Diff line number	Diff line change
`@@ -13107,15 +13107,15 @@ mod tests {`
`13107`	`13107`	`}`
`13108`	`13108`	`}`
`13109`	`13109`
`13110`		`- #[cfg(all(test, splicing))]`
	`13110`	`+ #[cfg(splicing)]`
`13111`	`13111`	`fn get_pre_and_post(pre_channel_value: u64, our_funding_contribution: i64, their_funding_contribution: i64) -> (u64, u64) {`
`13112`	`13112`	`use crate::ln::channel::PendingSplice;`
`13113`	`13113`
`13114`	`13114`	`let post_channel_value = PendingSplice::compute_post_value(pre_channel_value, our_funding_contribution, their_funding_contribution);`
`13115`	`13115`	`(pre_channel_value, post_channel_value)`
`13116`	`13116`	`}`
`13117`	`13117`
`13118`		`- #[cfg(all(test, splicing))]`
	`13118`	`+ #[cfg(splicing)]`
`13119`	`13119`	`#[test]`
`13120`	`13120`	`fn test_splice_compute_post_value() {`
`13121`	`13121`	`{`