Skip to content

Commit 51d0ef6

Browse files
committed
Mark several types no-export which should be exported eventually
1 parent 2a77d9a commit 51d0ef6

File tree

3 files changed

+8
-0
lines changed

3 files changed

+8
-0
lines changed

lightning-types/src/features.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -914,6 +914,7 @@ pub struct Features<T: sealed::Context + ?Sized> {
914914
mark: PhantomData<T>,
915915
}
916916

917+
/// This is not exported to bindings users but probably should be.
917918
impl<T: sealed::Context, Rhs: Borrow<Self>> core::ops::BitOrAssign<Rhs> for Features<T> {
918919
fn bitor_assign(&mut self, rhs: Rhs) {
919920
let total_feature_len = cmp::max(self.flags.len(), rhs.borrow().flags.len());
@@ -924,6 +925,7 @@ impl<T: sealed::Context, Rhs: Borrow<Self>> core::ops::BitOrAssign<Rhs> for Feat
924925
}
925926
}
926927

928+
/// This is not exported to bindings users but probably should be.
927929
impl<T: sealed::Context> core::ops::BitOr for Features<T> {
928930
type Output = Self;
929931

lightning/src/events/bump_transaction/mod.rs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -305,6 +305,8 @@ impl Utxo {
305305
}
306306

307307
/// Returns a `Utxo` with the `satisfaction_weight` estimate for a P2WPKH nested in P2SH output.
308+
///
309+
/// This is not exported to bindings users as WPubkeyHash is not yet exported
308310
pub fn new_nested_p2wpkh(outpoint: OutPoint, value: Amount, pubkey_hash: &WPubkeyHash) -> Self {
309311
let script_sig_size = 1 /* script_sig length */ +
310312
1 /* OP_0 */ +
@@ -324,6 +326,8 @@ impl Utxo {
324326
}
325327

326328
/// Returns a `Utxo` with the `satisfaction_weight` estimate for a SegWit v0 P2WPKH output.
329+
///
330+
/// This is not exported to bindings users as WPubkeyHash is not yet exported
327331
pub fn new_v0_p2wpkh(outpoint: OutPoint, value: Amount, pubkey_hash: &WPubkeyHash) -> Self {
328332
Self {
329333
outpoint,

lightning/src/ln/script.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,8 @@ impl ShutdownScript {
8585
///
8686
/// This function may return an error if `data` is not [BOLT-2] compliant.
8787
///
88+
/// This is not exported to bindings users as the `PushBytes` isn't currently mapped.
89+
///
8890
/// [BOLT-2]: https://github.com/lightning/bolts/blob/master/02-peer-protocol.md#closing-negotiation-closing_complete-and-closing_sig
8991
pub fn new_op_return<T: AsRef<PushBytes>>(data: T) -> Result<Self, InvalidShutdownScript> {
9092
Self::try_from(ScriptBuf::new_op_return(data))

0 commit comments

Comments
 (0)